Repository navigation
fix: update ldk node for lightning security fixes - #1475
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21ccedfe2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. This bumps com.synonym:ldk-node-android from 0.7.0-rc.71 to 0.7.0-rc.72 (the lightning 0.2.7 security fixes) in gradle/libs.versions.toml. Reviewed a7d7c7c, full tier because it changes a dependency pin.
What I checked, and 2 candidates I ruled out
Read in full: both changed files. The only ldk-node coordinate in the build is libs.versions.toml:68, and settings.gradle.kts already points to the synonymdev/ldk-node Maven repository.
Not built here: CI is the gate. CI (build) and Lint passed on this head, so the 0.7.0-rc.72 artifact resolves and compiles. E2E is still running.
Not verified here: that the published AAR's native libraries embed the 0.2.7 crates. That needs the package itself, and I could not fetch it from this review.
Ruled out
- rc.72 carries more than the dependency bump:
git diff v0.7.0-rc.71 v0.7.0-rc.72insynonymdev/ldk-nodetouches 7 files only:Cargo.toml(lightning,lightning-liquidity,lightning-transaction-syncto0.2.7, crate version),Cargo.lock(those three crates: 0.2.5, 0.2.3 and 0.2.1 to 0.2.7),Package.swift, the two Kotlingradle.properties,pyproject.tomlandCHANGELOG.md. The merge commit of #122 in the range adds no content on top of rc.71. Nosrc/, UDL or generated binding changed, so the app-facing API is the same as rc.71. - Stale pins left behind: the only other
rc.71strings in the branch are injourneys/pubky-marketplace/local-paykit-fallback.md, which is documentation.
Merge confidence: 4/5. Nothing found and the build is green, but this upgrades the Lightning node and only the E2E run exercises it, which had not finished when I reviewed.
|
Pushed 24fd170: the release note is now the fragment |
Twin: synonymdev/bitkit-ios#928
Refs: synonymdev/ldk-node#123
Description
0.7.0-rc.71to0.7.0-rc.72onmaster, so the node picks up thelightning,lightning-liquidityandlightning-transaction-sync0.2.7 security fixes. It reachesrelease-2.6.0whenmasteris merged in.0.7.0-rc.72is rc.71 with only those three dependencies updated (release).Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
Automated Checks
com.synonym:ldk-node-android:0.7.0-rc.72native libraries embedlightning,lightning-liquidityandlightning-transaction-sync0.2.7.