Repository navigation
feat(effect-e2e): record navigation timing, page reveal and layout shifts - #3
Merged
Merged
Conversation
…ifts Ported from systemfsoftware/systemfsoftware#860. Fixes the review's blocking finding: open now returns only once the navigation and reveal records are delivered, and the page reporter is installed only on engines that declare navigation-timing, for the main frame only. Claude-Session: https://claude.ai/code/session_017rX35xUAHEjVVaDKVVzubW
…veal The wait was satisfied by the about:blank entries the reporter also records, so open could return before the page's own reveal landed. Match on the opened URL, and have the navigation-records law say which entries it saw. Claude-Session: https://claude.ai/code/session_017rX35xUAHEjVVaDKVVzubW
systemfsoftware-bot
force-pushed
the
port-860
branch
from
October 29, 2026 19:40
a1b840a to
98aa9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of systemfsoftware/systemfsoftware#860 (paths mapped; no changesets in this repo).
Fixed from the review (CHANGES REQUESTED):
opennow returns only once the navigation and reveal entries are recorded (bounded wait), the law is unchanged.Follow-ups (P2/P3), not done here:
https://claude.ai/code/session_017rX35xUAHEjVVaDKVVzubW