Repository navigation
Conversation
foxploit
force-pushed
the
fix/underlying-network-interface-change
branch
from
October 8, 2026 18:57
3292ca2 to
db84543
Compare
Fixes issue where VPN tunnel wouldn't recreate when default network changed (e.g. cellular → Wi-Fi) but DNS/routes remained identical. The isConfigNonNilAndDifferent() check only compared router.Config and dns.OSConfig, missing interface changes. This caused traffic to keep routing through the old underlying interface (UnderlyingNetworks: Null). Changes: - Track lastUnderlyingIface/appliedUnderlyingIface in backend with mutex - Update NetworkChanged() to record new interface - Check interface change in isConfigNonNilAndDifferent() - Record applied interface after successful updateTUN() - Reset on CloseTUNs() - Add unit test for interface change detection Tested with log showing updateTUN executing on cellular→Wi-Fi transition instead of 'isConfigNonNilAndDifferent: no change to Routes or DNS, ignore'. Signed-off-by: foxploit <105010191+x0n3e@users.noreply.github.com>
foxploit
force-pushed
the
fix/underlying-network-interface-change
branch
from
October 8, 2026 18:59
db84543 to
8aafdd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where VPN tunnel wouldn't recreate when default network changed (e.g. cellular → Wi-Fi) but DNS/routes remained identical.
The isConfigNonNilAndDifferent() check only compared router.Config and dns.OSConfig, missing interface changes. This caused traffic to keep routing through the old underlying interface (UnderlyingNetworks: Null).
Changes:
Tested with log showing updateTUN executing on cellular→Wi-Fi transition instead of 'isConfigNonNilAndDifferent: no change to Routes or DNS, ignore'.