Repository navigation
Conversation
Report the route count and limit, and guide users to modify their tailnet ACLs to exclude this device from app connectors. Keep this warning visible while disconnected and during startup, clearing it only after a VPN tunnel is successfully configured. Add regression coverage for disconnected warnings, retries, and startup suppression. Updates tailscale/corp#49819 Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
barnstar
force-pushed
the
jonathan/route-limit-error
branch
from
October 9, 2026 19:09
23a4ccc to
0b99589
Compare
barnstar
changed the title
kari-ts
reviewed
Oct 9, 2026
| private val TAG = "health" | ||
| // These warnings can prevent connection. Show them while disconnected or warming up, | ||
| // until the backend clears them after the problem is resolved. | ||
| private val persistentWarnableCodes: Set<String> = setOf(ROUTE_LIMIT_CODE) |
Collaborator
There was a problem hiding this comment.
instead of special casing particular warnings, what if we track why tailscale stopped? eg
sealed interface DisconnectReason {
data object UserRequested : DisconnectReason
data class BackendFailure(val error: String) : DisconnectReason
}
and
val shouldShowHealthWarnings =
ipnState == Ipn.State.Running ||
(ipnState == Ipn.State.Stopped &&
disconnectReason is DisconnectReason.BackendFailure)
if the user intentionally disconnects they shouldn't see the route limit error imo.
also, in general I think it'd be good to surface warnings showing why connection failed (eg https://github.com/tailscale/tailscale-android/blob/main/libtailscale/backend.go#L198) and this might be a good way to take care of them?
| private fun routeLimitWarning() = | ||
| UnhealthyState( | ||
| WarnableCode = HealthNotifier.ROUTE_LIMIT_CODE, | ||
| Severity = Health.Severity.medium, |
Collaborator
There was a problem hiding this comment.
should this be a higher severity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#49819
Use a health warning to guide users to modify their tailnet
ACLs to exclude this device from app connectors when the number
of routes exceeds our internal cap.
Keep this warning visible while disconnected and during startup, clearing
it only after a VPN tunnel is successfully configured. Add regression
coverage for disconnected warnings, retries, and startup suppression.