Repository navigation
fix(publish): give the prepare call the ceiling qualify-release's jobs need - #228
Merged
Merged
Conversation
…s need v1.0.0's Publish run failed at startup: the prepare call granted contents: read, and GitHub checks every job of the called workflow against the caller's grant, including github-release (contents: write), which the prepare phase skips. The prepare job still declares contents: read.
tangletools
approved these changes
Oct 25, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — d48b8db0
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T00:15:59Z
drewstone
added a commit
that referenced
this pull request
Oct 25, 2026
fix(release): build before the tests that spawn the built CLI The v1.0.0 qualification (run 40146040321, after #228 fixed its startup) failed in `prepare`: `qualify-release.yml` ran `pnpm test` before `pnpm build`, and every CLI-spawning test failed on a missing `dist/cli.js`. ci.yml already builds first. The order is now typecheck, build, test, check:package; nothing else changes. Run ID: run_66835efe8253ce375017d831711d5b00
Merged
drewstone
added a commit
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.0 Publish run (40145858576) ended in
startup_failure.publish.ymlcallsqualify-release.yml@9563a87forpreparewithcontents: read, and GitHub checks every job of a called workflow against the caller's grant, skipped ones included; that file'sgithub-releasejob asks forcontents: write. agent-runtime's equivalent, whose called workflow holds only read jobs, publishes fine withread.The
preparecall now grantscontents: writeas a ceiling. The calledpreparejob still declarescontents: read, so its token is unchanged. The reviewed pin and runner-group allowance (qualify-release.yml@9563a87) are untouched.actionlintpasses apart from the self-hostedci-deploylabel it does not know.After merge: dispatch Publish with
existing_tag: v1.0.0, as docs/develop.md says for a failed publish.Run ID: run_66835efe8253ce375017d831711d5b00