Repository navigation
iris-gui: optional native macOS front-end (--features macos-gui) - #132
Closed
iblowmymind wants to merge 4 commits into
Closed
iblowmymind wants to merge 4 commits into
iblowmymind wants to merge 4 commits into
Conversation
iblowmymind
marked this pull request as draft
September 22, 2026 14:17
iblowmymind
marked this pull request as ready for review
September 22, 2026 14:30
iblowmymind
marked this pull request as draft
September 23, 2026 14:32
iblowmymind
force-pushed
the
mac-gui2
branch
10 times, most recently
from
October 5, 2026 08:17
b54c4e0 to
7438498
Compare
Rebuilds the mac-gui branch as an opt-in second layout on top of main. With the feature on, macOS gets the system menu bar, the configuration editor and every dialog in their own OS windows, and the run state in the window title. The default sidebar layout is unchanged and remains what every build gets; the feature is ignored off macOS. The backend lives in src/macos_native/. Dialogs are shared unchanged: in the native build they import an egui with Window swapped for an OS-window stand-in. main.rs has only a few cfg(native_mac) hooks. objc2-app-kit is an optional dependency, enabled only by the feature, with default features off.
…r Space
With the main window fullscreen on its own Space, closing the
Configuration window from the desktop Space and then returning to IRIS
aborted in glutin ("context to have a current view").
All windows share one GL context. While the main window is occluded,
eframe still runs its UI for a visible child window but skips painting
the main window, so the context stays attached to the child's view.
Dropping the child frees that view; the main window's next paint then
hits a nil view in glutin's is_view_current.
macos_native::end_frame now keeps a closed window alive, hidden, until
the main window has been painted since, and only then drops it.
… too menus.rs duplicates Action::ResetNvram separately from main.rs's sidebar menu handler (native NSMenu actions aren't shared code the way the config tabs are) -- it still only touched the DS1386 nvram file. Same fix as fix-nveeprom-path: reset and re-MAC both nvram and nveeprom, since Indigo2/IP28 read eaddr from the EEPROM instead.
menus.rs on macos_native builds the native Memory menu separately from main.rs's sidebar -- it still used the fixed RAM presets and only gated 256 MB banks on IP28. Use the profile-specific ram_presets helper from previous commits and gate all banks above 128 MB on IP28. This adds the 768/1024 MB presets and 512 MB bank entries Signed-off-by: iblowmymind <28228415+iblowmymind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the mac-gui branch as an opt-in second layout on top of main. With the feature on, macOS gets the system menu bar, the configuration editor and every dialog in their own OS windows, and the run state in the window title. The default sidebar layout is unchanged and remains what every build gets; the feature is ignored off macOS.
The backend lives in src/macos_native/. Dialogs are shared unchanged: in the native build they import an egui with Window swapped for an OS-window stand-in. main.rs has only a few cfg(native_mac) hooks. objc2-app-kit is an optional dependency, enabled only by the feature, with default features off.