Repository navigation
Embed IP28 PROM and use profile-specific fallback - #190
Merged
techomancer merged 1 commit intoOct 8, 2026
Merged
Conversation
Owner
|
convenient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP28 currently falls back to the embedded IP22 PROM when its configured ROM file is unavailable, preventing a normal IP28 boot. Embed the 512 KB
070-1477-002image insrc/prombinip28.rsand select it for the IP28 profile. The loader tries the configured path, then070-1477-002.binin the working directory, then the embedded IP28 image; IP22 retains its existing file precedence through the shared Indigo2 loader.Keep the embedded PROM choice available when selecting IP28 in New Machine, remove the external-ROM requirement warnings, and update the README, changelog, configuration example, and related documentation.
Validation:
a2c1cf6a8fcfe8e0bb8a82c77a0f3e4cb9b640fa995ee8a957069c993ede9246).cargo test --offline --locked --lib dev::prom::tests: 4 passed, including IP22/IP28 file precedence and full embedded-ROM bus reads.cargo check --offline --locked -p iris-gui: passed; GUI configuration controls were not smoke-tested interactively.git diff --check: passed.A 32 MB configuration failed PROM memory diagnostics with both the embedded image and an explicit load of the same ROM file. Memory sizing behavior is unchanged by this PR.