Repository navigation
Fix binary naming and deprecated atomic API build warnings - #191
Merged
Merged
Conversation
Owner
|
it needs the stupid elf binary update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo reports four non-kebab-case binary warnings, and GR2 uses the deprecated atomic
fetch_updatemethod. Rename the targets tochd-extract,jitv2-analyze,jitv2-verify, andjitv2-pcp-dump, and replace the GR2 call withtry_updatewhile preserving its orderings and saturating decrement.Update executable references across CLI messages, monitor help, workflows, docs, rules, and source comments. Audited every tracked file; remaining underscore names are Rust source filenames or the verifier test-directory identifier.
Validation:
cargo check -p iris --bins --features jitv2,j2wp --offline --lockedpassed without warnings.git diff --checkpassed.fin3_waits_for_queued_finishintermittently fails its early timing assertion; the same failure was reproduced with the originalfetch_updatecall.