Repository navigation
add after-version-update-hook.default-args.source.sh - #362
Merged
Merged
Conversation
robstoll
force-pushed
the
feature/after-version-update-hook
branch
from
October 14, 2026 06:14
f195c66 to
ba69893
Compare
using update-version-common-steps.default-args.source.sh in prepare-files-next-dev-cycle-template.sh was smelly to begin with. Doesn't matter that we don't use it in many places. Still better to define it consistently
robstoll
force-pushed
the
feature/after-version-update-hook
branch
from
October 14, 2026 06:18
ba69893 to
fc27191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using update-version-common-steps.default-args.source.sh in prepare-files-next-dev-cycle-template.sh was smelly to begin with. Doesn't matter that we don't use it in many places (i.e. turn optional params into required params). Still better to define it in after-version-update-hook.default-args.source.sh
moreover:
branchto after-version-update-hook.params.source.sh -- don't remember the exact use case but I am sure it will turn up again once we use the release templates in more gradle/sbt based projects)I confirm that I have read the Contributor Agreement v1.1, agree to be bound on them and confirm that my contribution is compliant.