Repository navigation
Forward kitchen sink signal arguments - #469
Conversation
9024117 to
89dbc1e
Compare
| // Arguments for the handler | ||
| repeated temporal.api.common.v1.Payload args = 4; | ||
| // Argument for the handler | ||
| temporal.api.common.v1.Payload arg = 4; |
There was a problem hiding this comment.
We only need one; a payload can contain lists inside if needed. Simpler.
There was a problem hiding this comment.
nit: Argument for the handler, uses lists to represent multi-arg input.
No strong feelings either way if you feel this is redundant.
a5a3316 to
98f37f4
Compare
98f37f4 to
9c9af99
Compare
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
I don't see a corresponding change for the Typescript worker
| // Arguments for the handler | ||
| repeated temporal.api.common.v1.Payload args = 4; | ||
| // Argument for the handler | ||
| temporal.api.common.v1.Payload arg = 4; |
There was a problem hiding this comment.
nit: Argument for the handler, uses lists to represent multi-arg input.
No strong feelings either way if you feel this is redundant.
|
d2ae1bf to
e1e2119
Compare
|
Oh I must have forgotten about this. Let me rebase :) |
e1e2119 to
be348be
Compare
Forward the existing
SendSignalAction.argspayloads from the Go, Java and Python kitchen sink workers instead of always delivering an empty signal.