Repository navigation
Conversation
The README example used a bounded ThreadPoolExecutor with an abort policy. A store or retrieve submits one task per payload, so any batch larger than the pool and queue combined was rejected and failed as a whole, and failed again on every retry. Recommend Executors.newVirtualThreadPerTaskExecutor() instead, which runs each GCS call on its own virtual thread and never rejects work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
store() built each claim before uploading and then read the object name back out of the claim map by key. Keep the object name and hash on PreparedPayload instead, and build the claim once the upload succeeds. retrieve() validated each hash with String.matches, which compiles the regex on every call. Use a precompiled Pattern. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
@jmaeagle99 this java GCS support is ready for review now, thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added an experimental Google Cloud Storage driver for external payloads and an adapter for the official Google Cloud Storage Java client.
Object names follow the existing GCS drivers' encoding and namespace layout, with a namespace-preserving fallback for long names. Claims use
object_name. Uploads leave existing objects unchanged, and downloads verify SHA-256 before decoding the complete payload, including metadata.The application owns the Google client and executor. Includes setup documentation and automatic integration tests against
fsouza/fake-gcs-server. Gradle downloads and caches a checksum-verified native binary; JUnit starts the server on a free local port and cleans up afterward.The quickstart uses
StorageOptions.grpc()for automatic DirectPath selection and includes a short note on preserving Google's runtime dependencies, service registrations, and Conscrypt native libraries when packaging an application.Why?
Store large Temporal payloads in GCS without writing a custom storage driver.
Related to temporalio/features#924.
Breaking changes?
No existing SDK API changes. The optional Google client adapter brings newer protobuf and gRPC dependencies.
Server PR
Not required.
Testing
./gradlew --offline spotlessApplypassed.build, including tests and Javadocs, with Java 21 and Java 8 release compatibility checks.