Repository navigation
Propagate Nexus serialization context to workflow updates - #3172
Open
JoshuaFrenchwood wants to merge 1 commit into
Open
JoshuaFrenchwood wants to merge 1 commit into
JoshuaFrenchwood wants to merge 1 commit into
Conversation
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 27, 2026 21:02
9cb96e2 to
cee99cc
Compare
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 28, 2026 15:46
cee99cc to
f31c42b
Compare
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 28, 2026 19:54
f31c42b to
67e8832
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Nexus operation handlers now propagate their
NexusSerializationContextto the workflow updatesthey send.
result, failure and rejection with it, and update handles decode with the context returned on the
update and poll responses.
Why?
A Nexus handler returns the result and failure of the update it sends to the Nexus caller. The
caller decodes them with the operation's
NexusSerializationContext, so a codec keyed on thecontext couldn't decode them when they were encoded with the workflow context.
Checklist
Closes
How was this tested:
WorkflowUpdateNexusSerializationContextTest: the in-memory server sends real updates with thecontext set, covering update result, failure, rejection and replay.
NexusSerializationContextPropagationTeston the dev server: a caller workflow goesthrough a Nexus endpoint to a handler that sends a workflow update.