Repository navigation
Fix OpenTelemetry logger attribute compatibility - #2035
Merged
Merged
Conversation
tconley1428
marked this pull request as ready for review
October 28, 2026 21:26
VegetarianOrc
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2029's missing
_ExtendedAttributesimport by typing logger scope attributes asMapping[str, Any] | Nonein the replay-safe provider and its tests. This retains string-keyed mapping checks while leaving value types permissive across OpenTelemetry versions. Extend forwarding coverage to absent, scalar, and nested attributes; leave dependency resolution and CI unchanged.