Repository navigation
feat(plan-work-items): classify each item's implementation, review, and expected paths - #111
Closed
taminomara wants to merge 1 commit into
Closed
taminomara wants to merge 1 commit into
taminomara wants to merge 1 commit into
Conversation
…nd expected paths Enrich the producer so each work item carries the markers the downstream driver needs, without pulling in the driver itself: - Add a Type field (deliverable / audit / spike) and rename Tests -> Checks in the work-item template. - Add Suggested implementation, Suggested review, Requires pre-work decisions, and Expected paths fields, selected via a new deliverable-skill catalog. - Direct project-manager to derive those markers and expected paths, and close the run with the three-bucket (unattended / pauses-for-human) recommendation. - Reframe the upstream unverified-assumptions guidance onto Requires pre-work decisions, since item-level HITL/AFK moves to the per-marker model. Split out of feat/autonomous-driver-core-loop as a standalone producer-side change; carries no implement-work-items edits. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BvgX88kC9h9xbe4zGLf7BC
Contributor
Author
|
Oh, also Also also, |
Collaborator
|
finally getting this pulled in, and rebased on to the v6 beta branch in #226 |
mxriverlynn
added a commit
that referenced
this pull request
Oct 15, 2026
…nd expected paths (#226) Replaces #111 by @taminomara, rebased onto `v6.0.0-beta` to resolve its merge conflicts. The original branch lives on a fork we can't push to, so this PR carries the same commit with @taminomara kept as the commit author. All credit for the change is theirs. ## What the change does `plan-work-items` now records, for each work item, which skill or agent should build it and which should review it, and whether each part can run unattended (`AFK`) or needs a human (`HITL`). Each item also records a `Type` (`deliverable`, `audit`, or `spike`), whether it needs a human decision before work starts, and the files it is expected to touch. A new deliverable-skill catalog maps each kind of deliverable to its suggested implementation and review. ## How the conflicts were resolved The skill changed a lot on `v6.0.0-beta` since #111 was opened, so the resolution adapts the change to the new shape rather than replaying it line for line: - The breakdown is now drafted by `plan-synthesizer`, not `project-manager`. The new directives sit beside the existing justification and drafting-order directives. - `v6.0.0-beta` removed the separate `Tests` block, so there is no `Checks` block. The audit and spike check guidance moved into `Acceptance criteria`. - `Summary` stays first. The classification fields (`Type`, `Requires pre-work decisions`, `Suggested implementation`, `Suggested review`, `Expected paths`) render after `Acceptance criteria` and before `Depends on`. - Catalog skill names updated for skills that moved out of `han-core` (`han-documentation:*`, `han-research:research`). - Long-form doc changes ported to its new home, `han-planning/docs/skills/plan-work-items.md`. Links to the `implement-work-items` doc were dropped, since that skill isn't in this repo yet; `SKILL.md` still offers it only when it is available. ## Open from #111 The original PR was a draft, and @taminomara noted `audit` and `spike` were meant to merge into one type before it was ready. That is still open, so this PR is also a draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft MR with diff to
plan-work-itemscherry-picked from my #96 WIP branch.The idea for the change:
plan-work-itemsgains knowledge about which skill or agent can be used to implement and review a particular work item. It also knows whether that skill/agent can finish work unattended, or if it's explicitly interactive. Based on this, each item gains classification: build AFK/HITL, and review AFK/HITL. Additionally, it gains a separate classification on whether an item requires making HITL decisions before it can be implemented (i.e. deferred OIs or assumptions that require human intervention before build starts).On top of it, it also adds work item types: deliverable is a regular "write code, then review"; audit is "verify something works and produce a report" (can be good for deferring OIs/assumptions into implementation, or adding verification that can't be done via tests); spike is for research or investigation items. Note that audit and spike are separate due to initial implementation constraints that I've eventually solved, so I'll merge them into one type before moving PR into ready state.
The change is not yet ready for deep review or merge, there are things to polish, edge cases to debug, and also I need to look at it with fresh eyes after working on something else for a bit. But you're welcome to comment on the general idea and approach. Or, well, you can review it, just know that this is not the final version.