Repository navigation
Fix webpack 5 browser builds - #548
Merged
Merged
Conversation
Fixes #531 Since 3.20.1, src/replace/index.js always imported can-register-loader, which requires Node's `module`. webpack 5 doesn't polyfill core modules, so every browser build failed with "Can't resolve 'module'". Move the loader check into src/replace/module/index.js, which the `browser` field already swaps out. The check still throws synchronously. Replace the store's `events` EventEmitter with a plain array, since `events` isn't a dependency and only resolved when something else installed it. Give the browser stubs a Node.js-only error for td.replaceEsm() and a listMockedModules() that returns [], so neither fails with a TypeError. Restore a webpack example that bundles both entry points for the web, runs them, and fails if a Node core module or a polyfill of one ends up in the bundle. Remove the test:example:plain-html script, whose example was deleted in 0825a6a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #531
Since 3.20.1, src/replace/index.js always imported can-register-loader, which requires Node's
module. webpack 5 doesn't polyfill core modules, so every browser build failed with "Can't resolve 'module'".Move the loader check into src/replace/module/index.js, which the
browserfield already swaps out. The check still throws synchronously. Replace the store'seventsEventEmitter with a plain array, sinceeventsisn't a dependency and only resolved when something else installed it.Give the browser stubs a Node.js-only error for td.replaceEsm() and a listMockedModules() that returns [], so neither fails with a TypeError.
Restore a webpack example that bundles both entry points for the web, runs them, and fails if a Node core module or a polyfill of one ends up in the bundle. Remove the test:example:plain-html script, whose example was deleted in 0825a6a.