Repository navigation
Conversation
PHP 8.6 gives DateTimeImmutable::add(), sub(), modify(), setDate(), setISODate(), setTime(), setTimestamp(), setTimezone() and createFromInterface() a tentative static return type. Safe's overrides return self, so declaring the class emits nine deprecation notices. Mark them #[\ReturnTypeWillChange], as createFromMutable() and __set_state() already are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 gives several
DateTimeImmutablemethods a tentativestaticreturn type.Safe\DateTimeImmutableoverrides them withself, so loading the class on 8.6 emits nine deprecation notices, for example:This marks
add(),sub(),modify(),setDate(),setISODate(),setTime(),setTimestamp(),setTimezone()andcreateFromInterface()with#[\ReturnTypeWillChange], ascreateFromMutable()and__set_state()already are.The new test loads the class in a separate process and asserts no deprecation is raised. It fails on 8.6.0-dev without the change. The full suite passes on PHP 8.1 to 8.6.