Repository navigation
fix: Find out again which API the server offers once it answers a path of the v2 API with 404 or 405, for example after a rollback. - #426
Merged
Conversation
…h of the v2 API with 404 or 405, for example after a rollback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
…nswer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
… v2 API, while observing events, and once a new probe finds the v2 API again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server is rolled back to a version without the v2 API, for example from 1.3 to 1.2, it answers every path of the v2 API with 404 or 405. Until now, the client kept sending v2 requests, and every one failed until the client was recreated.
Now, any answer with 404 or 405 to a request through the v2 API (single answers, streams, writes, and schema registration) makes the client forget which API the server offers, so the next request probes again. The request itself fails as before, and a write still ends with an
OutcomeUnknownError. A 404 through the v1 API and an error item with status 200 never forget. Only the transport that the client still keeps can make it forget, so a late 404 neither disturbs a probe in flight nor discards the answer of a newer one.The README section "Talking to Servers With and Without the v2 API" gets one sentence about this.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH