Repository navigation
chore: Stop observing in the tests once the expected events arrived, instead of after a fixed time. - #428
Merged
Conversation
…instead of after a fixed time. Four tests of observeEvents aborted observing after 100 milliseconds and then counted the events, so on a busy machine they could stop before the events arrived. They now stop once the expected number of events has arrived, and fail with the number they observed if the events have not arrived within 10 seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four tests in
src/observeEvents.test.tsaborted observing after a fixed 100 ms and then counted the events, so under load they could stop before the events arrived.The file passed 15 times in a row and 10 times with every core busy (load average around 30).
🤖 Generated with Claude Code
https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH