Repository navigation
Conversation
The KPB output pin 2 is bound to DMIC1_HOST_PIPELINE_SINK, which still uses the old host copier name 'copier.host.18.1'. The host copier is now named after its PCM ID, 'host-copier.11.capture', which is also what the routes use. When the DMIC16k PCM is opened, the kernel cannot find the host copier in the KPB pin binding and fails to bind the route in sof_ipc4_get_queue_id(): warning: W007 route 'kpb.19.1' -> 'host-copier.11.capture': 'host-copier.11.capture' is not in the output pin binding of 'kpb.19.1' (fails when PCM 'DMIC16k' capture is opened) Use the current host copier name. Only sof-dmic-4ch-wov changes. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Collaborator
Author
|
Found with the new tplg2 validator tool #11344 |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open issue
What changed in this PR
Updates the DMIC WoV topology default configuration to bind the KPB output pin to the correctly named host copier widget, fixing route binding failures when opening the DMIC16k capture PCM.
Changes:
- Replace legacy host copier widget name (
copier.host.18.1) with current PCM-ID-based name (host-copier.11.capture) forDMIC1_HOST_PIPELINE_SINK.
| File | Description |
|---|---|
| tools/topology/topology2/platform/intel/dmic-default.conf | Updates the DMIC1 host pipeline sink widget name to match the current host copier naming used by routes. |
Review effort: Lite
| DMIC1_DAI_PIPELINE_ID 19 | ||
| WOV_PIPELINE_ID 20 | ||
| DMIC1_HOST_PIPELINE_SINK 'copier.host.18.1' | ||
| DMIC1_HOST_PIPELINE_SINK 'host-copier.11.capture' |
Copilot stopped reviewing on behalf of
kv2019i due to an error
October 26, 2026 15:42
PR 11357: test resultsRun date: 2026-10-26 16:37 UTC Tested commit: 1a978f3213524c96e1d8b4bc3b6c463ca5a61ccf
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KPB output pin 2 is bound to DMIC1_HOST_PIPELINE_SINK, which still uses the old host copier name 'copier.host.18.1'. The host copier is now named after its PCM ID, 'host-copier.11.capture', which is also what the routes use. When the DMIC16k PCM is opened, the kernel cannot find the host copier in the KPB pin binding and fails to bind the route in sof_ipc4_get_queue_id():
warning: W007 route 'kpb.19.1' -> 'host-copier.11.capture':
'host-copier.11.capture' is not in the output pin binding of
'kpb.19.1' (fails when PCM 'DMIC16k' capture is opened)
Use the current host copier name. Only sof-dmic-4ch-wov changes.