Repository navigation
Rework remote execution filegroup builds to be local only - #3647
Open
peterebden wants to merge 1 commit into
Open
peterebden wants to merge 1 commit into
peterebden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently filegroups are created using a synthetic build action which the client pushes to the ActionCache. The approach has annoyed me for a while - it's inefficient and permission-wise I want to get to a point where Please never writes to the ActionCache.
This changes it so they are constructed entirely client-side; they are simply moving their inputs around so by definition we should always already have what we need.
I've run tests against a local REAPI setup and it behaves sensibly.