Repository navigation
Fix collapsed entries reopening after edits - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The child-first restoration correctly addresses the regression and the integration test covers both relevant states.
0 open findings
What changed in this PR
Preserves tree expansion state after edits by restoring child states before parent states.
Changes:
- Restores expansion states in child-first order.
- Adds a wx regression test and supporting gallery fixture.
- Documents the bug fix and registers the fixture in the gallery.
| File | Description |
|---|---|
construct_editor/core/construct_editor.py |
Applies child expansion states before parent states. |
tests/wx_integration/test_wx_construct_hex_editor.py |
Tests expanded and collapsed hidden-child states. |
construct_editor/gallery/test_array_with_bit_struct.py |
Adds the regression-test construct fixture. |
construct_editor/main.py |
Registers the fixture in the gallery. |
CHANGELOG.md |
Documents the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve tree expansion states when editing values. Previously, restoring an expanded child hidden inside a collapsed entry caused that entry to reopen unexpectedly.
Adds a wx integration regression test covering both expanded and collapsed child states, including reopening the parent manually. Both cases pass with the fix.