test: rename legacy test.rs and *_test.rs files to *_tests.rs - #23
Conversation
Each module keeps its name; its declaration gains a #[path] to the renamed file. Only names change, no test code does. Drops the legacy-files note from the guidance. Co-authored-by: Medulla <medulla@tinyhumans.ai>
…legacy-test-renames
Updated the pinned commit for the tinybus vendored dependency to include the latest upstream changes. Auto-committed-on: dragonfly
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Pending checks: TinyBus module E2E Could not review: crates/tinydocs-bus/src/error/mod.rs, crates/tinydocs-bus/src/spec/document/mod.rs, crates/tinydocs-bus/src/spec/image/mod.rs, crates/tinydocs-bus/src/spec/presentation/mod.rs, crates/tinydocs-module/src/outputs/mod.rs, crates/tinydocs-module/src/service/mod.rs, src/docx/mod.rs, src/pdf/mod.rs, src/pptx/mod.rs, tinysweeper/description, tinysweeper/e2e, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["Error<br/>changed"]:::changed
n1["DocumentSpec<br/>changed"]:::changed
n2["build<br/>changed"]:::changed
n3["extract_text<br/>changed"]:::changed
n4["generate"]:::impacted
n5["Result"]:::impacted
n6["from_bytes"]:::impacted
n7["generate_docx_holds_a_readable_document"]:::impacted
n8["invalid_input"]:::impacted
n9["check_image"]:::impacted
n3 -->|calls| n8
n4 -->|calls| n2
n5 -->|uses| n0
n6 -->|calls| n8
n7 -->|uses| n1
n9 -->|calls| n8
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (20)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTest modules in several Rust modules now load from ChangesTest module path updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This PR changes test-file resolution but does not introduce the reported cache race. No PR-specific merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
A rabbit checked each module path, Comment |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinydocs-bus/src/error/mod.rs, crates/tinydocs-bus/src/spec/document/mod.rs, crates/tinydocs-bus/src/spec/image/mod.rs, crates/tinydocs-bus/src/spec/presentation/mod.rs, crates/tinydocs-module/src/outputs/mod.rs, crates/tinydocs-module/src/service/mod.rs, src/docx/mod.rs, src/pdf/mod.rs and 4 more.
$0.0000 · 0 in / 0 out · 509 embedded · ladder/vectors
tinysweeper
Bot
added
the
priority: p3
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25290eb964
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit dc8c92f58b5dcb8b8af4a5b3a81aafe3333fa1e4 | |||
| Subproject commit df6f990cec3b130db12d6cd0c8e24f11c30b28e6 | |||
There was a problem hiding this comment.
This test-only commit also moves the pinned TinyBus revision from dc8c92f to df6f990. Because Cargo.toml patches all three TinyBus crates to this vendored path, the pointer change alters the compiled dependency despite the commit claiming no runtime behavior changes; revert it here and update the gitlink in a separately reviewed dependency commit.
AGENTS.md reference: AGENTS.md:L157-L160
Useful? React with 👍 / 👎.
| #[path = "mod_tests.rs"] | ||
| mod test; |
There was a problem hiding this comment.
After this patch removes the legacy exception that permitted keeping the old module name, all nine declarations still use mod test (or pub(crate) mod test) rather than the required mod tests. Rename these identifiers and update the presentation test's crate::spec::image::test reference so the newly renamed files actually follow the repository's declared test-module convention.
AGENTS.md reference: AGENTS.md:L280-L289
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
Renames 9 legacy test files (
test.rsand<name>_test.rs) to<module>_tests.rs(test.rsbecomes<declaring file>_tests.rs,mod_tests.rsbeside amod.rs). Each module keeps its identifier, so references to it keep resolving; its declaration gains a#[path]to the renamed file. Only file names and those attributes change, no test code. Removes the now-stale "legacy files" note from the guidance. Done with OpenHuman'sscripts/externalize-inline-tests.mjs --rename-legacy.Related issue
None.
API or behavior changes
None. Test-only files renamed; no public API or runtime behavior changes.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check(clean)cargo clippy --all-targets --all-features -- -D warnings(left to CI)cargo check --workspace --tests(passes;cargo build/cargo testleft to CI)cargo test --all-features(left to CI)Tests
No tests added or changed; 9 files renamed. Test bodies are untouched (git detects them as renames).
Documentation
CLAUDE.md/AGENTS.mdupdated.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit