Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async iteration never finishes when neither stdout nor stderr is piped, even after the child exits. For example:
combineStreams([])creates a stream that nobody ends. End it immediately when there are no inputs. The iterator still waits for the child to close, sothrowOnErrorcontinues to report nonzero exits. This also fixesstdio: 'inherit'without changing output capture.All four new regression cases time out on the previous code and pass with the fix. Full suite: 55 passed, 10 skipped on Node 24.19.0 and via the Bun 1.4.3 build/test command. Build, lint (including TypeScript and publint), and formatting pass.
Implemented and tested with Codex assistance.