Repository navigation
fix: decode split multibyte UTF-8 chunks in readStream with StringDecoder - #185
Open
kanchingyg wants to merge 1 commit into
Open
kanchingyg wants to merge 1 commit into
kanchingyg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
readStreaminsrc/main.tsconverts each stream chunk withchunk.toString(). When a subprocess writes UTF-8 output and a 2-, 3-, or 4-byte character is split across twoBufferchunks, each half is decoded in isolation and replaced withU+FFFD.This change uses
StringDecoder('utf8')fromnode:string_decoderinreadStream(decoder.write(chunk)per chunk followed bydecoder.end()) without mutating the stream encoding onthis.process.stdout.Added an async test in
src/test/main_test.tsthat synchronizes twostdoutwrites split mid-character (buf.subarray(0, 3)thenbuf.subarray(3)) and verifies the decoded output matches'ñé€🚀'.