Repository navigation
fix: decode stream chunks with StringDecoder to prevent multibyte corruption - #186
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #183.
In
readStream, buffer chunks were accumulated usingoutput += chunk.toString(). When a multibyte UTF-8 character (e.g. Cyrillic, CJK, emoji) is split across stream chunk boundaries, decoding each chunk individually causes incomplete byte sequences to be replaced by the Unicode replacement character (\uFFFD).This PR uses Node.js's standard
StringDecoderfromnode:string_decoderto buffer partial multibyte sequences across stream chunks and flush any remaining bytes on stream end.Changes
StringDecoderinreadStream()to safely decode chunks.src/test/main_test.tsverifying that multibyte UTF-8 characters split across stream writes are decoded without corruption.