Repository navigation
fix: allow _onWorkerAvailable to dispatch up to concurrentTasksPerWorker - #143
Closed
feritcemkahraman wants to merge 1 commit into
Closed
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove premature
eturn\ inside _onWorkerAvailable()'s while loop so queued tasks are dispatched up to \concurrentTasksPerWorker.
Problem
_onWorkerAvailable()\ iterates over \ askQueue\ / \skipQueue\ with:
\\ s
while (
(this.taskQueue.size > 0 || this.skipQueue.length > 0) &&
workerInfo.currentUsage() < this.options.concurrentTasksPerWorker
) { ... }
\`nHowever, the loop body previously ended with an unconditional
eturn, exiting immediately after dispatching a single task. When multiple tasks are queued and a worker has remaining concurrency capacity (or becomes available with capacity > 1), subsequent queued tasks remained in \ askQueue\ until another event or task completion occurred.
Removing
eturn\ lets the while loop continue filling the available worker up to \concurrentTasksPerWorker.
Validation