Repository navigation
Companion pets: keep docked pixel pets moving - #141
Merged
Merged
Conversation
…ement - Docked Clippy / Rover add a 1.5px vertical bob a quarter period apart from the sway. Drawn without smoothing, they only change once the offset crosses a pixel edge, so near each turning point of the lean they stood still for about two seconds and the "docked pet keeps swaying" check failed now and then. - The pet page test asserts that the resize grip stays below the collapsed card stack (its box covered the grip and swallowed the pointer). - docs/desktop-agent-office.md describes where the companion grip sits, why it holds still under the pointer, and the vertical bob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edge-peek, hit-area and grip commits on this branch already reached master through #140; this PR carries the one remaining commit.
docs/desktop-agent-office.mdexplains where the companion grip sits, why it holds still under the pointer, and the vertical bob.Verification (Windows):
node web/scripts/test-classic-desktop-pets.mjs: passed twice in parallel runs on the Windows host and twice with theACE_OFFICE_HOST=macshim.node web/scripts/test-desktop-office.mjs: passed on both hosts.desktop_pet_layout_test: 23 tests passed.desktop_pet.cppcompile check passed.Not verified: real macOS hardware, and the Windows desktop host running interactively.