Repository navigation
Simplify the chat code for Statamic 6 - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CP script and the
/!/front/configendpoint each built the user payload and HMAC separately, and the controller only readname(no first/last fallback). Both now go throughChatConfig::forCurrentUser(), which uses Statamic'sUser::name(). The provider passes a closure toStatamic::provideToScript(resolved per request) instead of wrapping it in astatamic::layoutview composer, and dropshotFilesince it matched the default.Two of the three CP CSS rules could never match:
#front-chat-containerlives inside Front's iframe, and.fc-1_tjFno longer exists (checked on transformstudios.com front end and CP, FrontChat 9.74.17). Only the#front-chat-iframez-index rule remains.vueand@vitejs/plugin-vue2were unused (cp.jsis plain DOM, vite config never loaded the plugin); dropped, with Vite andlaravel-vite-pluginbrought current. Assets rebuilt.Stacked on #32.