Repository navigation
Remove tsdate.evaluation module - #522
Merged
Merged
Conversation
hyanwong
force-pushed
the
remove-evaluation-module
branch
from
October 29, 2026 13:45
3f094a4 to
de2dff6
Compare
Member
Author
|
I assume you are OK with this @nspope ? This moves the AFS evaluation code (image below) out of the main tree and into an 
|
hyanwong
force-pushed
the
remove-evaluation-module
branch
from
November 2, 2026 18:43
be01963 to
1b373f6
Compare
Accuracy diagnostics are superseded by the scripts in evaluation/. Move the AFS diagnostics to evaluation/afs.py and the polytomy test helpers (remove_edges, unsupported_edges) to tests/utility_functions.py. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hyanwong
force-pushed
the
remove-evaluation-module
branch
from
November 2, 2026 19:03
1b373f6 to
b8b4315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accuracy diagnostics in
tsdate/evaluation.py(node_coverage,mutation_coverage,mutations_time) were unused and are superseded by the scripts inevaluation/.remove_edges/unsupported_edges(polytomy test helpers, used bytests/test_inference.py) move totests/utility_functions.pyafs_bias/allele_frequency_spectra(no equivalent in the new framework) move to a new scriptevaluation/afs.pyaccuracy.pyrow) and CHANGELOG entry addedThe module was undocumented and not exported from
tsdate/__init__.py.