Skip to content

ci: install the generated project's node and pnpm up front #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttncode merged 1 commit into from
Oct 15, 2026
Merged

ci: install the generated project's node and pnpm up front #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/runbook/bump-a-toolchain-version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ When: a pinned tool needs a new version, in the toolbox or in what it generates.

| Tool | Pinned in |
| --- | --- |
| This toolbox's tools: `bats`, `shellcheck`, `shfmt`, `yq`, `jq`, `zizmor`, `rush`, `lefthook`, `gitleaks` | `mise.toml` |
| This toolbox's tools: `bats`, `shellcheck`, `shfmt`, `yq`, `jq`, `zizmor`, `rush`, `node`, `pnpm`, `lefthook`, `gitleaks` | `mise.toml` |
| Every generated project: `node`, `pnpm`, `lefthook`, `gitleaks` | `common/mise.root.toml` |
| One adapter's toolchain, e.g. composer for `laravel-api`, node for `laravel-inertia` | `adapters/<name>/mise.toml` |
| `flask`'s python | `adapters/flask/.python-version` and the `--python` argument in `adapters/flask/adapter.env` |
| php | Not pinned: system php, checked by each Laravel adapter's `install` task (ADR-0016) |

2. Edit the version string. Leave the rest of the `[tools]` block alone.

3. `lefthook` and `gitleaks` are pinned twice. Change `mise.toml` and `common/mise.root.toml` together.
3. `node`, `pnpm`, `lefthook` and `gitleaks` are pinned twice. Change `mise.toml` and `common/mise.root.toml` together; `tests/contract.bats` fails when they differ.

4. Re-resolve this toolbox's lock.

Expand Down
74 changes: 74 additions & 0 deletions mise.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ yq = "4.48.1"
jq = "1.8.1"
zizmor = "1.29.0"
"ubi:shenwei356/rush" = "0.9.0"
# The same versions common/mise.root.toml pins into generated projects.
# The same versions common/mise.root.toml pins into generated projects, so CI
# installs them up front instead of each parallel test racing to install them.
node = "24.15.0"
pnpm = "11.21.0"
lefthook = "2.1.11"
gitleaks = "8.30.0"

Expand Down
16 changes: 16 additions & 0 deletions tests/contract.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,3 +294,19 @@ setup() {
false
}
}

@test "the toolbox pins every tool a generated project pins, at the same version" {
# Unpinned here, a project tool installs lazily inside each test; the unit
# lane's parallel jobs then race those installs, and mise 2026.9.11+ fails
# the losers with `"pnpm" couldn't exec process`.
local tool want got missing=""
while IFS= read -r tool; do
want="$(yq -p toml -oy ".tools.\"${tool}\"" "${SCAFFOLD_ROOT}/common/mise.root.toml")"
got="$(yq -p toml -oy ".tools.\"${tool}\"" "${SCAFFOLD_ROOT}/mise.toml")"
[ "$got" = "$want" ] || missing="${missing}${tool}: toolbox ${got}, project ${want}"$'\n'
done < <(yq -p toml -oy '.tools | keys | .[]' "${SCAFFOLD_ROOT}/common/mise.root.toml")
[ -z "$missing" ] || {
printf '%s' "$missing"
false
}
}
Loading