Repository navigation
gnulib-update.sh: avoid /tmp - #181
Merged
Merged
Conversation
Cloning into a predictable path in /tmp let another user on a multi-user system pre-create that directory with their own gnulib-tool, which would then be executed (the failed clone did not stop the script, and the rm -rf afterwards removed the evidence). Clone into gnulib-tmp/ inside the source tree instead, fail hard on errors, and clean up on exit. Assisted-by: GLM 5.3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #181 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 5 5
Lines 4215 4215
Branches 1006 1006
=======================================
Hits 3524 3524
Misses 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnulib-update.sh cloned gnulib into the predictable path /tmp/gnulib-update and then executed gnulib-tool from it. On a multi-user system another user could pre-create that directory with their own gnulib-tool; the failed git clone did not stop the script, so the attacker's gnulib-tool would run, with the trailing rm -rf removing the evidence.
Clone into gnulib-tmp/ inside the source tree instead, fail hard on errors (set -e), and clean up on exit (trap). Also add gnulib-tmp/ to .gitignore.
Reported by Solar Designer in dc88e96 (comment).