Skip to content

Update scala3-compiler, scala3-library, ... to 3.3.9 #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
typelevel-steward wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update scala3-compiler, scala3-library, ... to 3.3.9 #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f4c61
Update scala3-compiler, scala3-library, ... to 3.3.9
typelevel-steward[bot] Oct 28, 2026
0369194
Fix compilation for scala3
danicheg Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import com.typesafe.tools.mima.core._

val Scala213 = "2.13.18"
val Scala212 = "2.12.21"
val Scala3 = "3.3.7"
val Scala3 = "3.3.9"

ThisBuild / tlBaseVersion := "2.8"
ThisBuild / crossScalaVersions := Seq(Scala213, Scala212, Scala3)
Expand Down
3 changes: 2 additions & 1 deletion slf4j/src/main/scala/org/typelevel/log4cats/slf4j/internal/Slf4jLoggerInternal.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.typelevel.log4cats.slf4j.internal
import cats.effect.*
import org.slf4j.{Logger as JLogger, MDC}
import org.typelevel.log4cats.*
import org.typelevel.scalaccompat.annotation.unused

private[slf4j] object Slf4jLoggerInternal {

Expand All @@ -34,7 +35,7 @@ private[slf4j] object Slf4jLoggerInternal {

final class Slf4jLogger[F[_]](
val logger: JLogger,
sync: Sync.Type,
@unused sync: Sync.Type,

@danicheg danicheg Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't like this workaround because it's clearly a scala3 compiler quirk. sync is by no means unused. I'll try to submit a minimal repro to the scala/scala3 tracker.

@danicheg danicheg Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it goes scala/scala3#27449.

@danicheg danicheg Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we've got a response that it's deliberate new behavior in scala3. So, we have no choice but to @unused.

@rossabaker rossabaker Oct 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I guess it calls into question whether the deprecated constructor isn't correct again.

defaultCtx: Map[String, String]
)(implicit
F: Sync[F]
Expand Down
Loading