Repository navigation
build: bump gfmrun to v1.3.3 - #2472
Conversation
 [Medium impact] Changes how the build script installs a documentation tool. Resolve the relative install path before merging so Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ), | ||
| ) | ||
| if err != nil { | ||
| if err := os.Setenv("GOBIN", filepath.Dir(gfmrunExe)); err != nil { |
There was a problem hiding this comment.
Passing --top-dir . now makes installation fail when gfmrun is missing or outdated. This sets GOBIN to .local/bin, but go install requires an absolute path and rejects it. The previous downloader accepted this relative destination. Resolve topDir to an absolute path before changing directories and building the install path.
|
I believe in the long run, a better solution would be to add other architecture builds on |
asahasrabuddhe
left a comment
asahasrabuddhe
left a comment
There was a problem hiding this comment.
@Grivn As of gfmrun v1.3.3, darwin-arm64 binaries are now available. Please update your PR to bump the gfmrun version.
Grivn
changed the title
|
Thanks for adding the arm64 builds. Updated to v1.3.3 and restored the binary download, so the PR is now just the version bump. Verified the download on darwin/arm64, including |
2 participants
What type of PR is this?
What this PR does / why we need it:
make ensure-gfmrunfails on darwin/arm64 with HTTP 404 because gfmrun v1.3.0 has no binary for that platform. Bump to v1.3.3, which provides the missing binary, so the existing download-based installer works on Apple Silicon.Which issue(s) this PR fixes:
No existing issue.
Testing
On darwin/arm64 with Go 1.27.2:
make ensure-gfmrunand verified its version and release checksum.--top-dir .and that a second run reuses the installed binary.make all,make lint, andmake v3diffpass.Release Notes