Repository navigation
Conversation
990c8f9 to
0e76fee
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 92.62% 93.04% +0.42%
==========================================
Files 37 37
Lines 7808 7853 +45
Branches 392 365 -27
==========================================
+ Hits 7232 7307 +75
+ Misses 435 432 -3
+ Partials 141 114 -27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0e76fee to
81c85cf
Compare
Merging this PR will not alter performance1 warning
Comparing 
|
|
Commit 0e76fee has test result changes: bfs testsuite: |
| Some(utc_datetime.timestamp_millis()) | ||
| } else { | ||
| None | ||
| match re.ok()?.captures(date_str) { |
There was a problem hiding this comment.
let captures = re.ok()?.captures(date_str)?; would be simpler, no?
There was a problem hiding this comment.
Maybe so, but I intend to do the minimum necessary in this PR to bump edition to 2024.
| assert!(e.to_string().contains("expected an expression")); | ||
| } else { | ||
| panic!("parsing argument lists that end in -not should fail"); | ||
| match build_top_level_matcher(&[arg], &mut config) { |
There was a problem hiding this comment.
the auto-migration made these quite verbose
could you please use let Err(e) = ... else { panic!(...) }; or unwrap_err() instead? it's the same pattern ~25 times
| } | ||
| _ => { | ||
| eprintln!( | ||
| "WARNING: -L, -n and -I/-i are mutually exclusive, but more than one were given; \ |
There was a problem hiding this comment.
the string literal isn't reindented anymore, could you please fix it by hand?
There was a problem hiding this comment.
I don't know what you're asking for here, like this?:
eprintln!(
"WARNING: -L, -n and -I/-i are mutually exclusive, but more than one were given; \
only the last option will be used"
);
|
sorry but it needs to be rebased |
81c85cf to
5ba77e7
Compare
5ba77e7 to
41b1060
Compare
|
Commit 5ba77e7 has test result changes: bfs testsuite: |
|
Commit 41b1060 has test result changes: bfs testsuite: |
No description provided.