Repository navigation
texteditor: prevent infinite syntax highlighting rule loops - #1375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a file can freeze LiteIDE when syntax highlighting rules repeatedly match without consuming text. The hang report shows the main thread inside Highlighter::iterateThroughRules during rehighlighting after a file is opened.
Bound rule processing without character progress to 1024 checks per offset, and limit recursive child/fallthrough evaluation to 128 levels. On either limit, use the existing broken-highlighter fallback to stop syntax highlighting for the document while preserving its text. Clear the context stack on failure and log the block, offset, and context.
Add a standalone QtTest target covering nine scenarios: look-ahead with #stay, base-context #pop, context cycles, empty string matches, fallthrough loops, recursive children, consuming rules, and valid look-ahead transitions. Normal cases also verify formatting of a 4096-character line.
Validation:
The report does not identify the exact triggering file or rule; the regression test reproduces the same class of non-progressing rule loop.