Repository navigation
Robj/iterator init options pr - #694
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…lpers Start position becomes an optional parameter; zero value is a full forward scan. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…b_optimize Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…it and core_range_iterator_init Adds key_lower_limit/key_upper_limit/key_start_position (internal-key analogues of the public types). Merges core_range_iterator_init_with_filter into core_range_iterator_init. Drops redundant range params from core_memtable_iterator_init. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d btree_pack_req_init Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Deploy Preview for splinterdb canceled.
|
…g-braces) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
A zero-initialized key has kind 0, which is not NULL_KEY, so every iterator created without a filter was rejected with STATUS_BAD_PARAM. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Renumber key_type to NEGATIVE_INFINITY = -1, USER_KEY = 0, POSITIVE_INFINITY = 1, so a zero-initialized key is exactly NULL_KEY and there is one representation of "no key". The order is preserved for data_key_compare's kind subtraction; static asserts guard both properties. key_type values are never persisted. With that, limits no longer need a "present" flag: a null key means unbounded and the comparison is ignored. Start positions become a direction plus an exclusive flag instead of a comparison, so their zero value is the default forward, inclusive scan. Public limits are validated only when they have a key. Removes the kind == 0 workaround in core_range_iterator_init. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier to initialize iterators and lookup_result structures.