Repository navigation
fix: make data component type registry optional for pre-1.20.5 versions - #56
Merged
Merged
Conversation
Registries for 1.20.4 and older have no minecraft:data_component_type entry, so deserialization threw and broke every registry lookup for those versions. The registry is now nullable and the data component type lookups return their not-found values when it is absent. Fixes #55 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
Problem
MinecraftRegistrydeclaredminecraft:data_component_typeasrequired. Data component types were added in 1.20.5, soregistries.jsonfor 1.20.4 and older doesn't have that entry. Deserialization threwJsonExceptionfor those versions, which broke every registry lookup (MinecraftItemRegistry,MinecraftMenuRegistry, ...), not only data component types.Changes
MinecraftRegistry.MinecraftDataComponentTypeRegistryis now optional and nullable.MinecraftDataComponentTypeRegistry.GetId/GetIdentifierreturn their not-found values (-1/null).Void.MinecraftandVoid.Proxy.Apito 0.6.0..omcdirectory.Verification
Built with 0 warnings and 0 errors. A throwaway console app run against the bundled resources gave:
stonecustom_dataThe repo has no test project, so this PR doesn't add a regression test.
🤖 Generated with Claude Code