Repository navigation
feat: add deterministic read-only runtime doctor - #466
efraespada merged 31 commits into
Conversation
…-doctor-command-in-github
…-doctor-command-in-github
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 2595000 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Treat ambiguous content 404s as unavailable —
src/data/repository/github/runtime_doctor_repository.ts:42
Bugbot: review incomplete
Incomplete coverage
|
|
/copilot fix "runtime_doctor_repository.ts:42:ambiguous-content-404" |
Request could not be completed
Action: Inspect the sanitized agent status and retry if appropriate. Retained state: Existing persisted state and completed external effects were preserved. Error code: Retryable: Yes Reference: |
|
/copilot diagnose El flujo fix del comentario 6112079942 recuperó el head correcto y terminó sin cambios. Investiga el acceso al repositorio desde el sandbox de Windows. Distingue observaciones de hipótesis, indica qué operación de lectura falla y su código de error si puedes reproducirlo. No leas credenciales, perfiles privados ni variables de entorno; no cambies permisos, configuración o archivos. |
|
The repository read attempt failed before PowerShell or Verified: This sandbox blocked process creation for the read command, so I could not inspect repository files or reproduce a file-access error. Hypothesis: The failure is an execution-policy restriction on launching the shell, rather than evidence of a missing repository or denied access to a particular file. The exact restriction and any underlying file-read behavior remain unverified. Next step: Retry the same read through an approved repository browsing or shell execution path. No credentials, profiles, environment variables, permissions, configuration, or files were accessed or changed. Request interpreted from SpanishInterpreted request The fix flow for the comment 6112079942 recovered the correct head and finished without changes. Investigate repository access from the Windows sandbox. Distinguish observations from hypotheses, and indicate which read operation fails and its error code if you can reproduce it. Do not read credentials, private profiles, or environment variables; do not change permissions, configuration, or files. Original request /copilot diagnose El flujo fix del comentario 6112079942 recuperó el head correcto y terminó sin cambios. Investiga el acceso al repositorio desde el sandbox de Windows. Distingue observaciones de hipótesis, indica qué operación de lectura falla y su código de error si puedes reproducirlo. No leas credenciales, perfiles privados ni variables de entorno; no cambies permisos, configuración o archivos. |
|
/copilot diagnose Aísla el rechazo previo del shell: al invocar exec_command indica explícitamente login=false, porque este runtime deshabilita los shells de login. Haz únicamente una lectura de existencia del archivo src/data/repository/github/runtime_doctor_repository.ts mediante .NET en PowerShell, sin perfiles, sin credenciales ni variables de entorno y sin modificar nada. Indica si el proceso llega a arrancar y si el archivo existe; distingue el resultado observado de una hipótesis. |
|
The PowerShell process did not start: the command was rejected by policy before execution. Therefore, the file’s existence was not checked and remains unknown. The rejection alone does not establish that login-shell handling caused the failure. Request interpreted from SpanishInterpreted request Isolate the previous shell rejection: when invoking exec_command, explicitly specify login=false because this runtime disables login shells. Perform only an existence read of the file src/data/repository/github/runtime_doctor_repository.ts using .NET in PowerShell, without profiles, credentials, or environment variables, and without modifying anything. State whether the process starts and whether the file exists; distinguish the observed result from a hypothesis. Original request /copilot diagnose Aísla el rechazo previo del shell: al invocar exec_command indica explícitamente login=false, porque este runtime deshabilita los shells de login. Haz únicamente una lectura de existencia del archivo src/data/repository/github/runtime_doctor_repository.ts mediante .NET en PowerShell, sin perfiles, sin credenciales ni variables de entorno y sin modificar nada. Indica si el proceso llega a arrancar y si el archivo existe; distingue el resultado observado de una hipótesis. |
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 2f496c5 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Workflow check can pass when the Copilot action is unrelated to the trigger —
src/application/policies/github_runtime_doctor_policy.ts:47
Request could not be completed
Action: Inspect the current state and retry the failed step. Retained state: Existing persisted state and completed external effects were preserved. Error code: Retryable: Yes Reference: |
|
/copilot sync-branch |
Request could not be completed
Action: Inspect the current state and retry the failed step. Retained state: Existing persisted state and completed external effects were preserved. Error code: Retryable: Yes Reference: |
|
/copilot sync-branch |
Request could not be completed
Action: Inspect this validation code in the workflow logs and correct the resolution before retrying /copilot sync-branch. Retained state: No synchronization commit was pushed; remote branches were preserved. Error code: Retryable: Yes Reference: |
|
/copilot sync-branch |
…-doctor-command-in-github
Branch synchronized
The fixer resolved 18 conflicted files. 6 verification checks passed. |
|
/copilot recheck |
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit aa57311 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- low: Large static matrices can be reported as runnable —
src/application/policies/doctor_workflow_matrix_policy.ts:11 - low: Help issues can be incorrectly reported as blocked —
src/application/usecases/read_copilot_doctor_workflow.ts:44
|
/copilot recheck |
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit b205cec was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- low: Reject the invalid single-
@branch ref —src/domain/github_runtime_doctor.ts:105 - low: Catalog check can pass with unregistered specifications —
src/application/policies/github_runtime_doctor_policy.ts:39
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit b205cec was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: An empty trusted policy read is treated as verified absence —
src/domain/github_runtime_doctor.ts:68
|
/copilot dismiss "src/domain/github_runtime_doctor.ts:105:accepts-invalid-at-ref" |
|
1 finding was dismissed. |
|
/copilot recheck |
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 07689fb was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: A dependent job can be reported as eligible when its prerequisite is skipped —
src/application/policies/github_runtime_doctor_policy.ts:87
|
/copilot recheck |
|
/copilot history |
There was a problem hiding this comment.
Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on3247da7. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit d5b5f74 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Treat incomplete repository samples as unavailable —
src/application/policies/github_runtime_doctor_policy.ts:22
Operation historyGeneral conversation comments Showing 10 supported requests
|
|
/copilot recheck |
|
Maintainer audit of 3247da7: the native review completed all five diff partitions, reported no new candidates, and reconciled the current finding inventory to open=0, unknown=0, fixed=17, obsolete=4, dismissed=1. Its partial-coverage result is retained: two human SDD answers exceeded the bounded model sample. I read both complete Q1–Q7 answers separately and checked the no-model/no-write, independent evidence, exact-target, absence-versus-unavailable and reply-freshness contracts against the implementation and regression evidence. The full local suite and normal hooks passed 603 suites / 8,552 tests with 35 existing skips and all coverage budgets. Current-head platform and RepoWise checks remain a separate merge gate; this comment is not producer attestation or bot approval. |
/copilot doctorreports seven independent groups of bounded, non-secret configuration and GitHub evidence through typed read-only ports. It separates proven blocked prerequisites from unavailable reads, preserves successful independent facts, and publishes one English/Spanish correlated reply without model, repair, approval or repository mutation authority.Workflow evidence is pinned to one verified default-branch revision and regular tracked blobs. Explicitly missing files are blocked; malformed or incomplete provider samples remain unavailable, preserving independent successful facts. Conservative literal matrices must have at most 256 jobs; unsupported dynamic evidence remains unavailable. Jobs with directly skipped needs cannot establish eligibility; other dependent runtime outcomes stay unavailable. Unique enabled help issues have no branch/SDD obligation even when their form is incomplete; disabled/conflicting kinds retain their admission block. Approval policy comes from the existing authoritative Variables reader and strict parser, with declared producer health kept separate from verified health.
Validation on 3247da7: 300 distinct Doctor cases; full 603 suites / 8,552 passing tests, 35 existing skips; all global/module budgets, pure matrix 100%, build, TypeScript, lint, documentation/specification and normal commit hooks passed. Six matrix/help regressions and eight policy/catalog regressions failed before correction; the alleged single-at ref defect was disproved and explicitly dismissed through the native command, with quiet replay verified. The Action previously resolved 18 parent conflicts, passed all six checks, regenerated bundles before trusted staging and published aa57311; current-head native checks/review and post-promotion live acceptance remain required.
Closes #461.