Repository navigation
feat: compare verified first and current SDD revisions - #469
efraespada merged 17 commits into
Conversation
…current-sdd-revisions
…current-sdd-revisions
…current-sdd-revisions
…current-sdd-revisions
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Estado actual: La cobertura global es parcial; esta instantánea no demuestra que todos sus hallazgos estén resueltos.
Última reconciliación enc04bf45. Ver estado agregado de Bugbot.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit cb6b369 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Treats any multiple closing issues as ambiguous —
src/application/usecases/sdd/sdd_diff_query_use_case.ts:31 - low: Require the SDD diff result to have executed —
src/application/policies/semantic_result_publication_policy.ts:191
Bugbot: revisión incompleta
Cobertura incompleta
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #469 +/- ##
===========================================
+ Coverage 93.20% 93.27% +0.07%
===========================================
Files 881 887 +6
Lines 27344 27645 +301
Branches 7937 8040 +103
===========================================
+ Hits 25485 25786 +301
Misses 740 740
Partials 1119 1119
🚀 New features to boost your workflow:
|
|
/copilot dismiss "src/application/policies/semantic_result_publication_policy.ts:191:sdd-diff-requires-execution" |
|
1 finding was dismissed. |
…ostflight-error-reporting into feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions
Branch synchronized
The fixer resolved 15 conflicted files. 6 verification checks passed. |
Copilot status
|
|
/copilot sync-branch --dry-run --no-agent |
|
Dry run complete — merging |
…ns: require source witnesses for SDD comparison publication
|
/copilot sync-branch |
…current-sdd-revisions
Branch synchronized
The fixer resolved 16 conflicted files. 6 verification checks passed. |
…ns: Preserve fail-closed comment publication after SDD integration
|
/copilot recheck |
There was a problem hiding this comment.
Estado actual: La cobertura global es parcial; esta instantánea no demuestra que todos sus hallazgos estén resueltos.
Última reconciliación enc04bf45. Ver estado agregado de Bugbot.
🤖 Instantánea de la revisión de Bugbot
Bugbot reportó 1 problema potencial cuando se analizó el commit 4cafaf8. Esta instantánea es histórica; usa el bloque de estado superior para conocer el estado actual. 1 hallazgo está enlazado al código modificado.
Hallazgos
- low: El presupuesto de pruebas citado no coincide con el inventario —
specs/pre-branch-sdd-diff.md:293
|
Manual maintainer context audit for head The initial native PR review covered every code partition and retained no open or unknown findings. The subsequent explicit recheck found one documentation inconsistency ( |
…ns: Correct SDD comparison test-budget reference
|
/copilot recheck |
The deterministic
/copilot sdd-diffcommand compares verified immutable first/current SDD publications and returns bounded structural changes with English/Spanish evidence links. Every PR projection rechecks its native issue association, and stale or pending results preserve historical publications without claiming current comparison counts.The integrated implementation also preserves the shared fail-closed source-comment publication guard. Three missing-reader regressions failed before correction; comment replies and operation receipts now withhold all publication effects without an authoritative request witness.
Validation on
c04bf45d: 254 distinct comparison cases, plus three separately allocated shared publication regressions; 622 suites with 9,105 passed and 35 configured skips. Coverage budgets, types, lint, documentation, workflows, specifications, generated bundles and normal hooks passed. Action-owned synchronization resolved 16 conflicts and passed all six configured checks. Current-head CI, RepoWise and hosted Ubuntu/Mac/Windows checks passed. All four code review partitions completed with zero open or unknown findings; review remains neutral because one long SDD answer was truncated, with its full context manually audited in comment6150156897. Live revision-pair acceptance follows primary-branch promotion.Closes #464