Skip to content

feat: compare verified first and current SDD revisions - #469

Merged
efraespada merged 17 commits into
developfrom
feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions
Oct 13, 2026
Merged

efraespada merged 17 commits into
developfrom
feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions

Conversation

@efraespada

@efraespada efraespada commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

The deterministic /copilot sdd-diff command compares verified immutable first/current SDD publications and returns bounded structural changes with English/Spanish evidence links. Every PR projection rechecks its native issue association, and stale or pending results preserve historical publications without claiming current comparison counts.

The integrated implementation also preserves the shared fail-closed source-comment publication guard. Three missing-reader regressions failed before correction; comment replies and operation receipts now withhold all publication effects without an authoritative request witness.

Validation on c04bf45d: 254 distinct comparison cases, plus three separately allocated shared publication regressions; 622 suites with 9,105 passed and 35 configured skips. Coverage budgets, types, lint, documentation, workflows, specifications, generated bundles and normal hooks passed. Action-owned synchronization resolved 16 conflicts and passed all six configured checks. Current-head CI, RepoWise and hosted Ubuntu/Mac/Windows checks passed. All four code review partitions completed with zero open or unknown findings; review remains neutral because one long SDD answer was truncated, with its full context manually audited in comment 6150156897. Live revision-pair acceptance follows primary-branch promotion.

Closes #464

@docs-page

docs-page Bot commented Oct 12, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~469

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title [#464] Compare verified first and current SDD publications [#464] ✨ - Dogfooding compare verified first and current SDD revisions Oct 12, 2026
@vypbot
vypbot self-requested a review October 12, 2026 14:17
@vypbot vypbot added this to vypdev Oct 12, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 12, 2026
@vypbot
vypbot changed the base branch from develop to master October 12, 2026 14:17
@efraespada efraespada linked an issue Oct 12, 2026 that may be closed by this pull request
1 task done
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 12, 2026
@vypbot
vypbot changed the base branch from master to develop October 12, 2026 14:18
@vypbot vypbot added the 90% Progress: 90% label Oct 12, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estado actual: La cobertura global es parcial; esta instantánea no demuestra que todos sus hallazgos estén resueltos.
Última reconciliación en c04bf45. Ver estado agregado de Bugbot.

🤖 Bugbot review snapshot

Bugbot reported 2 potential problems when commit cb6b369 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.

Findings

  • medium: Treats any multiple closing issues as ambiguous — src/application/usecases/sdd/sdd_diff_query_use_case.ts:31
  • low: Require the SDD diff result to have executed — src/application/policies/semantic_result_publication_policy.ts:191

Comment thread src/application/usecases/sdd/sdd_diff_query_use_case.ts Outdated
Comment thread src/application/policies/semantic_result_publication_policy.ts
@vypbot

vypbot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: revisión incompleta

Estado actual: La revisión de c04bf45 tiene cobertura parcial; no puede declarar limpio el pull request completo.

Acción: No consideres completa esta revisión. Revisa las fuentes en Cobertura incompleta e inspecciona manualmente los elementos omitidos; repite la revisión solo después de reducir el alcance relevante o restaurar el acceso al proveedor.

Cobertura incompleta
  • selection: complete; conservados=1
  • issue-comments: complete; conservados=53
  • pull-request-comments: complete; conservados=8
  • review-threads: complete; conservados=7
  • diff: complete; conservados=42
  • previous-findings: complete; conservados=1
  • human-conversation: partial; conservados=25, truncados=1
  • rules: complete; conservados=1

Pull request · Commit verificado · Ejecución

@vypbot

vypbot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot unverified.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: c04bf45deedc; base: 106d85e11c92; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (106d85e) to head (c04bf45).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
+ Coverage    93.20%   93.27%   +0.07%     
===========================================
  Files          881      887       +6     
  Lines        27344    27645     +301     
  Branches      7937     8040     +103     
===========================================
+ Hits         25485    25786     +301     
  Misses         740      740              
  Partials      1119     1119              
Files with missing lines Coverage Δ
src/application/policies/agent_activity_policy.ts 100.00% <100.00%> (ø)
...application/policies/copilot_interaction_policy.ts 100.00% <ø> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <ø> (ø)
...c/application/policies/sdd_diff_message_catalog.ts 100.00% <100.00%> (ø)
...plication/policies/sdd_diff_presentation_policy.ts 100.00% <100.00%> (ø)
...ion/policies/semantic_result_publication_policy.ts 97.15% <100.00%> (+0.04%) ⬆️
src/application/ports/sdd_evidence_read_ports.ts 100.00% <ø> (ø)
...on/usecases/comment_automation_command_workflow.ts 90.90% <100.00%> (+0.90%) ⬆️
...application/usecases/comment_automation_context.ts 97.87% <100.00%> (+0.57%) ⬆️
...pplication/usecases/comment_automation_use_case.ts 91.66% <ø> (ø)
... and 11 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot dismiss "src/application/policies/semantic_result_publication_policy.ts:191:sdd-diff-requires-execution"

@vypbot

vypbot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

1 finding was dismissed.

…ostflight-error-reporting into feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions
@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

bugfix/474-dogfooding-fixer-scratch-cache-rejection-and-stale-postflight-error-reporting was merged into feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions and pushed as 94653aa5e5c11d5448d3f633b7eda455bf0fd858.

The fixer resolved 15 conflicted files.

6 verification checks passed.

@vypbot

vypbot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Copilot status

  • Repository: vypdev/copilot
  • Target: pull-request / PR feat: compare verified first and current SDD revisions #469 / issue ✨🧑‍💻 - Dogfooding compare verified first and current SDD revisions #464
  • Event: issue_comment (edited)
  • Branch: feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions
  • Lifecycle: blocked
  • Waiting for: maintainer
  • PR description policy: replace
  • Issue labels: enhancement, branched, size: XXL, priority: low, feature, 85%, in-progress, SDD, state:working
  • PR labels: size: XXL, 85%, state:blocked, state:awaiting-maintainer
  • Bugbot findings: Current finding counts could not be verified.
  • Exact-head PR readiness: not applicable (recommend; Commit c04bf45; protected-path)
  • CI: blocked
  • Coverage: blocked
  • Bugbot: blocked
  • Native reviews: satisfied
    View verified PR
    Next action: Have a maintainer review this exact revision.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch --dry-run --no-agent

@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Dry run complete — merging develop into feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions has 16 conflicts. Nothing was pushed and no agent was invoked.

…ns: require source witnesses for SDD comparison publication
@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into feature/464-dogfooding-compare-verified-first-and-current-sdd-revisions and pushed as 20e817bd0fa2ad9cf940e4b9d4a1c02ea646a3ff.

The fixer resolved 16 conflicted files.

6 verification checks passed.

…ns: Preserve fail-closed comment publication after SDD integration
@efraespada efraespada changed the title [#464] ✨ - Dogfooding compare verified first and current SDD revisions feat: compare verified first and current SDD revisions Oct 13, 2026
@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estado actual: La cobertura global es parcial; esta instantánea no demuestra que todos sus hallazgos estén resueltos.
Última reconciliación en c04bf45. Ver estado agregado de Bugbot.

🤖 Instantánea de la revisión de Bugbot

Bugbot reportó 1 problema potencial cuando se analizó el commit 4cafaf8. Esta instantánea es histórica; usa el bloque de estado superior para conocer el estado actual. 1 hallazgo está enlazado al código modificado.

Hallazgos

  • low: El presupuesto de pruebas citado no coincide con el inventario — specs/pre-branch-sdd-diff.md:293

Comment thread specs/pre-branch-sdd-diff.md Outdated
@efraespada

efraespada commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

Manual maintainer context audit for head c04bf45deedcdc0fabc1356d57a5654add42a4a8: I read the full SDD answers, including the long initial Q1–Q8 comment 6107269964, the native-relationship clarification 6107482941, and the stale/pending clarification. They agree with the implementation's native PR linkage, immutable publication verification, fixed comparison bounds, historical-only stale evidence, EN/ES presentation and no-model/read-only contract.

The initial native PR review covered every code partition and retained no open or unknown findings. The subsequent explicit recheck found one documentation inconsistency (4261227328): an exclusion sentence still cited 240 cases beside a 250-case table. Commit c04bf45d corrected that sentence, and recheck run 38430602310 marked the finding fixed. All four code partitions completed with zero open, reopened, verification-required or unknown findings; no code finding was added. Its partial status truthfully reflects one truncated human-context item; this manual audit does not change the bot's coverage claim or check conclusion. Three integration regressions also reproduced and corrected the missing-reader publication fallback before push; all normal verification passed.

…ns: Correct SDD comparison test-budget reference
@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@vypbot vypbot added state:ai-processing 85% Progress: 85% and removed 90% Progress: 90% state:ai-processing labels Oct 13, 2026
@efraespada
efraespada merged commit 91b2b03 into develop Oct 13, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Dogfooding compare verified first and current SDD revisions

3 participants