[#472] 🐛 - Dogfooding reconcile completed issue metadata and native closed status

[efraespada]

Merging a verified same-repository PR reconciles completion metadata: active/waiting/progress labels are selectively removed and 100% is added only for native completed closure. Every write checks fresh issue state/reason and preserves unrelated labels. Reopening blocks an old delivery from closing the issue again; partial effects are reported honestly.

Status reads current native issue/PR state, preserves verified historical SDD links and keeps inspection guidance for missing or invalid proof. Its final native issue read also fences the complete label set after SDD and linked PR count collection, so it cannot mix changed eligibility with earlier SDD evidence. Current duplicate closure is supported without inventing completed progress.

Validation on 0e347f46: 111 new completion/status cases plus 12 separately allocated SDD companion cases; 581 suites with 7,940 passed and 35 configured skips. Coverage budgets, types, lint, docs/specifications, bundles and normal hooks passed. Fresh native review/checks and merge → issue completion → current status/replay acceptance remain pending.

Closes #472

[docs-page]

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~473

Documentation is deployed and generated using docs.page

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 0e347f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit f742118 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

• low: Reject lifecycle labels that collide with progress labels — src/domain/issue_completion.ts:35

[vypbot]

Bugbot: 1 finding needs attention

Current status: 1 finding requires attention on 0e347f4.

Action: Review the linked threads or comment /copilot fix all.

Findings

• open — The close adapter can close an issue reopened after its first check

Pull request · Verified commit · Workflow run

[vypbot]

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 0e347f46b99c; base: aa10ee66e2b0; reason: protected-path.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 96.15385% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.03%. Comparing base (aa10ee6) to head (0e347f4).

Files with missing lines	Patch %	Lines
...cation/usecases/sdd/sdd_evidence_query_use_case.ts	81.81%	1 Missing and 1 partial ⚠️
.../steps/issue/close_issue_after_merging_use_case.ts	95.65%	0 Missing and 2 partials ⚠️
...ta/repository/issue/issue_completion_repository.ts	95.45%	0 Missing and 2 partials ⚠️
src/application/policies/status_command_policy.ts	96.15%	0 Missing and 1 partial ⚠️
...plication/usecases/read_copilot_status_workflow.ts	96.15%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
+ Coverage    93.01%   93.03%   +0.01%     
===========================================
  Files          847      850       +3     
  Lines        26036    26203     +167     
  Branches      7446     7515      +69     
===========================================
+ Hits         24217    24377     +160     
- Misses         742      743       +1     
- Partials      1077     1083       +6     

Files with missing lines	Coverage Δ
...pplication/policies/publication_message_catalog.ts	100.00% <ø> (ø)
src/application/policies/sdd_status_policy.ts	100.00% <100.00%> (ø)
src/application/ports/sdd_evidence_read_ports.ts	100.00% <100.00%> (ø)
...on/usecases/comment_automation_command_workflow.ts	91.89% <100.00%> (ø)
src/application/usecases/issue_comment_use_case.ts	94.87% <100.00%> (+0.13%)	⬆️
src/application/usecases/issue_workflow_context.ts	84.09% <ø> (ø)
...n/usecases/pull_request_review_comment_use_case.ts	100.00% <100.00%> (ø)
...lication/usecases/pull_request_workflow_context.ts	100.00% <100.00%> (ø)
src/data/model/labels.ts	100.00% <100.00%> (ø)
src/domain/issue_completion.ts	100.00% <100.00%> (ø)
... and 9 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[efraespada]

/copilot fix "src/domain/issue_completion.ts:35:lifecycle-progress-collision"

[vypbot]

Request could not be completed

Impact: The operation did not accept the supplied input.

Action: Correct the input and retry.

Retained state: No new state or external effect was created.

Error code: validation.invalid-input

Retryable: No

Reference: 37594575-0b0a-4cdb-8e2b-c997afc8a7da

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 0e347f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 6ff3f89 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

• low: Unavailable SDD evidence is marked historical — src/application/usecases/read_copilot_status_workflow.ts:42

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 0e347f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit f235c07 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

• low: Final status fence ignores issue label changes — src/application/usecases/read_copilot_status_workflow.ts:45

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 0e347f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 2 potential problems when commit 58a9abd was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.

Findings

• medium: Issue status can be stale while Bugbot counts are collected — src/application/usecases/read_copilot_status_workflow.ts:47
• low: Label objects without a name are accepted as the string "undefined" — src/data/repository/issue/issue_completion_repository.ts:34

[efraespada]

The missing-label-name finding is a false positive. Running the current production adapter against a native-shaped response with labels=[{}] rejects it with provider.contract-invalid. The mapping preserves JavaScript undefined; isIssueCompletionLabelName checks typeof value === string before length, so no string conversion occurs. A literal label named "undefined" is a separate valid string. I dismissed this finding through the native command; no redundant guard or test-count increase is needed.

[vypbot]

1 finding was dismissed.