[#474] 🐛 - Dogfooding fixer scratch cache rejection and stale postflight error reporting

[efraespada]

Closes #474.

Fixer scratch caches are ignored without weakening sensitive-file checks. Verification now captures generated bundles before scoped staging, so a source fix cannot pass its commands and push a stale Action bundle. Existing unrelated changes stay excluded.

Error and read-only query replies refresh the same owned comment only after verifying the exact current request. Every comment-correlated reply requires a valid request witness, including immutable mutation receipts; missing or changed sources withhold publication. Read-only commands avoid hidden configuration writes.

Validation: 73 disjoint regressions across semantic publication (56), execution (11) and autofix (6). Full suite: 585 suites, 8,015 passed, 35 configured platform skips. Global/module coverage, typecheck, lint, documentation, specifications, generated bundles and normal commit hooks passed. The Action synchronized the branch with current develop; no manual parent merge was performed.

Live dogfooding reproduced scratch rejection, stale error replies and missing generated bundles. The latest native review also reproduced the missing-witness path with three failing regressions; the current commit closes it. Fresh native review/checks are required before merge.

[docs-page]

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~477

Documentation is deployed and generated using docs.page

[vypbot]

Bugbot: review complete

Current status: No active findings on 37ee567.

Pull request · Verified commit · Workflow run

[vypbot]

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 37ee567285b0; base: 678968d8df49; reason: protected-path.

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 37ee567. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit c08543e was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

• medium: Mutation replies can be published without verifying the source request — src/application/usecases/steps/common/reply_publication_workflow.ts:44

[codecov-commenter]

Codecov Report

❌ Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.04%. Comparing base (678968d) to head (37ee567).

Files with missing lines	Patch %	Lines
src/actions/github_action_completion.ts	66.66%	0 Missing and 1 partial ⚠️
...n/usecases/steps/common/publish_resume_workflow.ts	91.66%	0 Missing and 1 partial ⚠️
...secases/steps/common/reply_publication_workflow.ts	94.11%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #477   +/-   ##
========================================
  Coverage    93.03%   93.04%           
========================================
  Files          850      853    +3     
  Lines        26205    26284   +79     
  Branches      7516     7550   +34     
========================================
+ Hits         24379    24455   +76     
  Misses         743      743           
- Partials      1083     1086    +3     

Files with missing lines	Coverage Δ
...tion/policies/application_error_message_catalog.ts	100.00% <ø> (ø)
...ation/policies/configuration_persistence_policy.ts	100.00% <100.00%> (ø)
...s/steps/commit/bugbot/commit_and_push_preflight.ts	89.74% <100.00%> (+4.55%)	⬆️
...es/steps/commit/bugbot/commit_and_push_workflow.ts	100.00% <100.00%> (ø)
.../usecases/steps/commit/workspace_mutation_guard.ts	93.75% <ø> (ø)
...n/usecases/steps/common/publish_resume_use_case.ts	100.00% <100.00%> (ø)
src/data/model/application_error.ts	100.00% <ø> (ø)
src/data/repository/reply_request_repository.ts	100.00% <100.00%> (ø)
src/domain/reply_request_digest.ts	100.00% <100.00%> (ø)
...ture/composition/reply_request_composition_root.ts	100.00% <100.00%> (ø)
... and 3 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vypbot]

Request could not be completed

Impact: The workflow could not complete the requested operation.

Action: Inspect the current state and retry the failed step.

Retained state: Existing persisted state and completed external effects were preserved.

Error code: workflow.failed

Retryable: Yes

Reference: a1943e0d-fc2a-4fdf-852c-f547b81100f6

[efraespada]

/copilot sync-branch

[vypbot]

Branch synchronized

develop was merged into bugfix/474-dogfooding-fixer-scratch-cache-rejection-and-stale-postflight-error-reporting and pushed as bf94de57834d274049b7c20da406d38a28509df3.

The fixer resolved 2 conflicted files.

6 verification checks passed.

[efraespada]

/copilot recheck

[vypbot]

Current status: All findings originating in this review are resolved.
Last reconciled on 37ee567. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit bf94de5 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

• low: Missing request snapshots bypass the source check — src/application/usecases/steps/common/reply_publication_workflow.ts:45

[efraespada]

/copilot recheck