Repository navigation
Protect compiler inputs and strengthen Whale lowering validation - #911
Merged
LunaStev merged 2 commits intoOct 12, 2026
Merged
Conversation
Address wavefnd#901, wavefnd#902, wavefnd#905 and wavefnd#906 with pre-write alias checks and input-preservation regressions. Signed-off-by: LunaStev <luna@lunastev.org>
Update the official format-4 dependency and address wavefnd#868, wavefnd#900, wavefnd#877, wavefnd#907 and wavefnd#869. Keep native Whale execution unsupported and the LLVM default unchanged. Signed-off-by: LunaStev <luna@lunastev.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent compiler artifacts and validation reports from overwriting source or linker inputs. Update the Whale dependency to format 4, preserve existing numeric-condition, void-call and floating-negation semantics, and execute the supported integer lowering subset with the bounded upstream interpreter.
Motivation
AST-only output did not protect imported sources, MSVC companion output paths could alias inputs, and report guards omitted Whale sources, std files and local case imports. The Whale adapter also lacked HIR bool conversions for numeric conditions, rejected grouped void calls, and used multiplication for floating negation, which cannot preserve signaling NaN bits.
Closes #901
Closes #902
Closes #905
Closes #906
Closes #868
Closes #900
Closes #877
Closes #907
Closes #869
Related to #773. This adds its narrow integer oracle test layer, not the complete cross-backend parity harness.
Target and compatibility impact
--whaleCLI, supported targets and the development version unchanged.06577d657a242ffdd60f07db5bd788d110fc66ab; round-trip generated format-4 IR through its reader and verifier.Validation
Passed with Rust 1.89.0 and local LLVM 21:
Checklist
Signed-off-byline.std/.