Repository navigation
Build the event extension from its PECL release archive - #260
Merged
Merged
Conversation
The event PIE package downloads its source from Bitbucket, so a Bitbucket outage failed every image build. Build the same 3.1.6 release from the checksummed PECL archive with the same configure options, like the other source-built extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every image build failed during the Bitbucket outage, which blocked the release with the critical PHP security fixes.
Cause
The
eventextension was installed through a package whose source code is hosted on Bitbucket. While Bitbucket was degraded, each build waited and then failed to download it ("Could not authenticate against bitbucket.org").Solution
Build the same
event3.1.6 release from the official PECL release archive instead, the same way other extensions such asoauth,imagickandxhprofare already built. Bitbucket is no longer needed. The archive is checked against a fixed checksum, and the extension keeps the same version and build options.Details
8/install-extensions.sh:install_pie osmanov/pecl-event:3.1.6 …→install_source event-3.1.6 5b74554c6370aae8c284c8110fe27e071d3f663953c3eb762ffc429b0a3c83a2 . …, with the same configure flags (--enable-event-sockets --with-event-libevent-dir=/usr --with-event-extra=yes --with-event-openssl --with-openssl-dir=yes).https://pecl.php.net/get/event-3.1.6.tgz. The archive keepsconfig.m4at its top level, like the other PECL archives built here.Validation
bash -n 8/install-extensions.shpasses, and so do the build reliability tests (python3 -m unittest discover -s 8/tests -p 'test_*.py', 8 tests).