Repository navigation
Keep Brotli round-trip tests without CVE version checks - #263
Merged
Merged
Conversation
Remove the hardcoded minimum Brotli version assertion from the functional test. Continue testing compression and decompression behavior; verify security package versions when rebuilding release images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Brotli functional test rejects patched distribution releases solely because their upstream version is below 1.2.1.
Cause
A permanent minimum-version assertion was added for a one-time security update, even though security fixes can be backported to other release branches.
Solution
Keep testing Brotli compression and decompression behavior. Check security package versions during release verification instead of maintaining this CVE-specific version gate in the functional suite.
Validation