Repository navigation
fix(ci): green the nightly type-drift guard and Bun parity runs - #1021
Merged
Merged
Conversation
Type drift: the guard runs `vitest --typecheck.only` after `build:types` alone, but global setup still hydrated test credentials, importing @workglow/storage source whose @workglow/util import resolves to a dist/node.js nothing built. A typecheck-only run executes no test and needs no keys, so it skips global setup. Bun parity: the startAnthropicMock port-taken test matched EADDRINUSE in the message, which only Node's wording carries; Bun says "Failed to start server. Is port N in use?". Assert the error code instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XhkN9hb996BFHvKgiFUSdr
![mergestorm-vortex[bot]](https://avatars.githubusercontent.com/in/3924858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two nightly workflows on
mainare red for unrelated reasons; this fixes both.Nightly type-drift guard
Failing every night with
Failed to resolve entry for package "@workglow/util".The job runs
build:typesonly, thenvitest run --typecheck --typecheck.only …. Vitest's global setup still ran and hydrated the test credentials, which imports@workglow/storagesource; its@workglow/utilimport resolves throughexportsto adist/node.jsthat a types-only build never writes. A--typecheck.onlyrun executes no tests and needs no keys, sovitest.config.tsnow skips global setup in that mode.Nightly Bun parity
One failing test since Oct 15:
startAnthropicMock > rejects when its port is already taken. It matched/EADDRINUSE/against the error message, which only Node's wording carries. Bun rejects with"Failed to start server. Is port N in use?"and the samecode: "EADDRINUSE". The test now asserts the code.Verification
bun run build:typesthen the job's vitest command); after the fix: 3 type tests pass, no type errors.examples/agent-eval/src/test/runCodingAgent.test.ts: 9/9 pass under bothbun testand vitest (Bun 1.4.3, Node 24).oxfmt --checkandoxlintclean on both files.Generated by Claude Code