Repository navigation
chore(main): release 10.5.0 - #559
workos-sdk-automation[bot] wants to merge 3 commits into
Conversation
[Medium impact] The PR appears safe to merge, though the release notes should disclose the Admin Portal method rename. FindingsFix with agent prompt### Issue 1
CHANGELOG.md:199
The new 10.5.0 notes list only three user-management changes for #565. That change also renames `AdminPortal#create_revoke_link` to `AdminPortal#revoke_link` without keeping the old method. Customers relying on these notes will not know that existing calls raise `NoMethodError` after upgrading. Please document the rename as a breaking change.
### Issue 2
CHANGELOG.md:16-19
The 10.5.0 entry says these two models and their enums were removed, but later lists the same names as added. Neither model appears in the 10.4.0 release or the current SDK. This makes it harder for customers to tell what changed or whether they need to migrate.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryThe PR prepares the 10.5.0 release by updating version metadata, moving pending entries into the changelog, and updating the lockfile.
Reviews (3) · Last reviewed commit: "chore: update Gemfile.lock" · Reviewed by Greptile |
bcaf1f5 to
9ed1114
Compare
| * Removed model `AddDataIntegrationsUpsertApiKeyRequest` | ||
| * Removed model `AddDataIntegrationsUpsertClientCredentialsRequest` | ||
| * Removed enum `AddDataIntegrationsUpsertApiKeyRequestConnectionOwner` | ||
| * Removed enum `AddDataIntegrationsUpsertClientCredentialsRequestConnectionOwner` |
There was a problem hiding this comment.
Contradictory Pipes release notes The 10.5.0 entry says these two models and their enums were removed, but later lists the same names as added. Neither model appears in the 10.4.0 release or the current SDK. This makes it harder for customers to tell what changed or whether they need to migrate.
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 16-19
Comment:
**Contradictory Pipes release notes** The 10.5.0 entry says these two models and their enums were removed, but later lists the same names as added. Neither model appears in the 10.4.0 release or the current SDK. This makes it harder for customers to tell what changed or whether they need to migrate.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.7b189d0 to
e78c2db
Compare
| * Changed errors for endpoint `POST /connections` | ||
| * Changed errors for endpoint `POST /connections/{connectionId}/saml_sp_signing_cert` | ||
|
|
||
| * [#565](https://github.com/workos/workos-ruby/pull/565) feat(generated)!: regenerate from spec (3 changes) |
There was a problem hiding this comment.
Admin Portal rename omitted The new 10.5.0 notes list only three user-management changes for #565. That change also renames
AdminPortal#create_revoke_link to AdminPortal#revoke_link without keeping the old method. Customers relying on these notes will not know that existing calls raise NoMethodError after upgrading. Please document the rename as a breaking change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 199
Comment:
**Admin Portal rename omitted** The new 10.5.0 notes list only three user-management changes for #565. That change also renames `AdminPortal#create_revoke_link` to `AdminPortal#revoke_link` without keeping the old method. Customers relying on these notes will not know that existing calls raise `NoMethodError` after upgrading. Please document the rename as a breaking change.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
🤖 I have created a release beep boop
10.5.0 (2026-10-15)
Features
AdminPortal.create_revoke_linkwas renamed toAdminPortal.revoke_link(#565) (b3d8713)Bug Fixes
POST /user_management/authenticate(#565) (b3d8713)This PR was generated with Release Please. See documentation.