Repository navigation
fix(sweetlink): stop probing ws://localhost from remote page origins - #44
Merged
Merged
Conversation
The candidate builder always appended a ws://localhost:<port> fallback. On remote origins (factory preview hostnames, tunnels) that dials the viewer's own machine: it always fails, and on macOS 15+ it triggers a per-origin Local Network permission prompt. Gate localhost candidates on the page origin being a local hostname (localhost/127.0.0.1/*.localhost/*.test); remote origins now attempt same-origin endpoints only. Explicit wsUrl overrides are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
buildSweetlinkWsUrlCandidatesalways ended the candidate list with aws://localhost:<port>fallback. For pages served from remote origins (factory preview hostnames, tunnel URLs), that dial targets the viewer's machine:Fix
Gate the
ws://localhost:*candidates on the page origin being a local development hostname (localhost/127.0.0.1/*.localhost/*.test— reusing the existingisLocalDevelopmentHostname). Remote origins now attempt same-origin endpoints only (wss://<host>/__sweetlink), which is also the correct priority for the factory preview WebSocket relay (DEV-14160). ExplicitwsUrloverrides remain honored on any origin.Local dev behavior is unchanged (all existing local-origin tests pass as-is).
Validation
vitest run packages/sweetlink/src/types.test.ts— 36/36vitest run packages/devbar/src— 1159/1159