Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes have no identified blocking issues and leave executable code and build settings unchanged.
No open issues 🎉
What changed in this PR
Extends Chapter 10’s linking guidance across C++98–26 while preserving the C++20 build baseline.
Changes:
- Adds material on inline variables, module linkage, initialization ordering, LTO, platform symbols, and ABI boundaries.
- Numbers body sections to align with the chapter validator introduced in PR #15.
| File | Description |
|---|---|
01_low_level/10_linking/README.md |
Expands modern linking guidance and normalizes section headings. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed Chapter 10 against its existing examples and expanded senior-level material: ODR, inline variables, module linkage, LTO, init ordering, platform symbols, and ABI. Normalized numbered H2 sections for the Python validator introduced in PR #15. C++20 build baseline unchanged; documentation-only.