Repository navigation
Import new device diagnostics - #797
TheJulianJES wants to merge 17 commits into
Conversation
6a74739 to
a7ae4c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #797 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 61 61
Lines 10870 10870
=======================================
Hits 10597 10597
Misses 273 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5054.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5011.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5012.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5013.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5023.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5070.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5024.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5024.
New-device snapshot for the quirk added in zigpy/zha-device-handlers#5112.
a7ae4c3 to
d6b1c51
Compare
New-device snapshot provided in zigpy/zha-device-handlers#5435, which fixes the current-temperature mapping for this quirk (unreleased; regenerates properly with the next zha-quirks release).
From zigpy/zha-device-handlers#5472 (diagnostics dump attached by the author, imported against that PR's quirk at 4344da00).
|
Added The dump was taken with the author's custom quirk ( TODO @TheJulianJES: grab that diagnostics dump on fresh HA with latest quirk above merged. |
From zigpy/zha-device-handlers#5318 (diagnostics dumps attached by the author, imported against that PR's quirk at 42a3db4d).
|
@zigpy-review-bot update this PR |
…new-20260624 # Conflicts: # tests/data/devices/bituo-technik-spm01x-0x0000000e.json # tests/data/devices/ctm-lyng-ax-valve-controller-0x0000002a.json # tests/data/devices/heiman-hm-722esy-e-plus-0x00000010.json # tests/data/devices/heiman-hs1ca-e-plus-0x00000020.json # tests/data/devices/heiman-relaymodule-ef-3-0-0x00000015.json # tests/data/devices/heiman-smokesensor-ef2-3-0-0x00000015.json # tests/data/devices/sonoff-snzb-02ld-0x00001100.json # tests/data/devices/third-reality-inc-3rdp01072z-0x00000030.json # tests/data/devices/third-reality-inc-3rwp01073z-0x00000030.json
|
Merged Nine of the diagnostics files added here had conflicted with the versions #922 already added to Full suite on the merged head: 1781 passed, 4 failed. The 4 failures are |
|
@zigpy-review-bot Update again, note quirks 2.4.0 bump was merged. Check CI/tests. |
|
Merged Full suite before the regen: 1782 passed, 3 failed (exactly those 3 snapshots). After it, The SONOFF TRV-ZBT dump itself still comes from the author's custom quirk (Adaptive mode via |
|
Replaced The new snapshot is Full suite on the new head: 1785 passed. CI is running on 9af9637. |
|
@zigpy-review-bot Also check recently merged quirks issues and PRs for other diagnostics and add them here (unless they're clearly modified/fake or generated with some old/custom quirk version). Possibly also check lots of other issues and PRs for diagnostics that could be added, but perhaps first start with what was recently merged (and those related issues/PRs). |
Adds 12 device diagnostics found in recently merged zha-device-handlers PRs and their linked issues, all with the merged quirk applied: - Aqara FP1 `lumi.motion.ac01` (zigpy/zha-device-handlers#5440) - Aqara pet feeder `aqara.feeder.acn001` (zigpy/zha-device-handlers#5296) - Candeo C-ZB-RD1Pv2 DPM and REM (zigpy/zha-device-handlers#5268) - CentraLite 3300 without endpoint 2 (zigpy/zha-device-handlers#5507) - ELECRAM Ramses_esp32c6 (zigpy/zha-device-handlers#4782) - Tuya `_TYST11_qq9mpfhw` water leak sensor (zigpy/zha-device-handlers#5524) - Tuya TS0043 `_TZ3000_famkxci2` (zigpy/zha-device-handlers#5475) - Tuya TS1201 `_TZ3290_gnl5a6a5xvql7c2a` (zigpy/zha-device-handlers#5516) - Tuya TS0601 `_TZE284_9m4kmbfu` (zigpy/zha-device-handlers#5469) - Tuya TS0601 `_TZE284_aaeaifez` (zigpy/zha-device-handlers#5411) - Tuya TS0601 `_TZE284_loejka0i` (zigpy/zha-device-handlers#5526)
|
Added 12 diagnostics in f6abc1d (plain commit on top, no force push). I went through the quirks PRs merged since 2026-09-15 and their linked issues, collected every attached diagnostics JSON, and ran them all through
Full suite on the new head: 1797 passed (1785 before plus the 12 new snapshots). Things to look at:
Not done: the "lots of other issues and PRs" part. I only covered recently merged PRs and their linked issues, not older merged PRs, open PRs, or unrelated issues. Re-mention me to take that on, and say how far back or which labels or devices to look at. |
There was a problem hiding this comment.
🔵 Needs a closer look
The fixtures depend on zha-quirks 2.1.0, and quirk matching and diagnostics round-trip behavior could not be verified against that release.
No open issues 🎉
What changed in this PR
Adds 14 device diagnostic fixtures to ZHA’s test data, expanding coverage of devices supported by quirks. This PR changes test data only; regeneration is planned with zha-quirks 2.1.0.
Changes:
- Imports device signatures, cluster attributes, and firmware metadata.
- Records entity configurations and states for thermostats, sensors, remotes, a feeder, and other devices.
| File | Description |
|---|---|
| tests/data/devices/tze284-loejka0i-ts0601-0x0000004a.json | Adds electrical measurement and energy sensor diagnostics. |
| tests/data/devices/tze284-aaeaifez-ts0601-0x0000004e.json | Adds thermostat diagnostics with configuration controls. |
| tests/data/devices/tze284-9m4kmbfu-ts0601-0x00000050.json | Adds battery-powered thermostat and valve-position diagnostics. |
| tests/data/devices/tze200-znzs7yaw-ts0601-0x00000048.json | Adds Haozee thermostat diagnostics and temperature settings. |
| tests/data/devices/tz3290-gnl5a6a5xvql7c2a-ts1201-0x00000043.json | Adds Zosung infrared blaster diagnostics. |
| tests/data/devices/tz3000-famkxci2-ts0043-0x00000048.json | Adds three-button remote and battery diagnostics. |
| tests/data/devices/tyst11-qq9mpfhw-q9mpfhw-0x00000049.json | Adds moisture sensor and power-type diagnostics. |
| tests/data/devices/none-aqara-feeder-acn001-0x00002621.json | Adds Aqara feeder controls and dispensing statistics. |
| tests/data/devices/heiman-hm-636thv-ac-m-0x01000000.json | Adds smoke, carbon monoxide, and environmental diagnostics. |
| tests/data/devices/elecram-ramses-esp32c6-0x00050100.json | Adds ELECRAM device signature and firmware diagnostics. |
| tests/data/devices/ctm-lyng-ax-water-sensor-0x00000019.json | Adds water-leak sensor and battery diagnostics. |
| tests/data/devices/centralite-3300-0x10015100.json | Adds contact, temperature, and battery sensor diagnostics. |
| tests/data/devices/candeo-c-zb-rd1pv2-rem-0x00000016.json | Adds rotary dimmer remote and electrical metering diagnostics. |
| tests/data/devices/aqara-lumi-motion-ac01-0x00000036.json | Adds presence sensor diagnostics and detection settings. |
Review effort: Balanced
This adds some new device diagnostics provided in quirks PRs. See the corresponding PRs in the commit details.
More commits will be pushed to this branch. They'll only regenerate properly with the next zha-quirks release (2.1.0).
There's also another branch for regenerated diagnostics that needs to be pulled into the next bump for quirks here:
https://github.com/zigpy/zha/tree/zigpy-bot/diagnostics-regenerated-20260624