Repository navigation
fix(ziggurat): Keep router children out of the child table backup - #78
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Router promotion leaves the receiver flag unset, causing traffic to remain queued for nonexistent polls, and deterministic regression tests for child expiry and scheduling are missing.
2 open issues
What changed in this PR
This PR addresses #77 by separating router children from end-device keepalive handling and backup exports.
Changes:
- Restricts keepalive eviction and deadline scheduling to end-device children.
- Reclassifies restored end-device entries as routers when they send Link Status.
- Excludes router children from protocol child exports.
| File | Description |
|---|---|
crates/ziggurat-zigbee/src/nwk/neighbors.rs |
Filters keepalive handling by device type and corrects router classification on Link Status. |
crates/ziggurat-protocol/src/bridge.rs |
Exports only end-device children for backup. |
Review effort: Balanced
puddly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77.
Per the spec, children can be both routers and end-devices. These were streamed out during network backup and ended up in zigpy's child table (which should be just end device children) and were restored back as such. This is a bug. I've also added a runtime fix to flip the device type of a child if a link status is received.